Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor messageformat-parser, moving from PEG.js to moo #288

Merged
merged 6 commits into from
Sep 13, 2020
Merged

Refactor messageformat-parser, moving from PEG.js to moo #288

merged 6 commits into from
Sep 13, 2020

Commits on Sep 5, 2020

  1. build(parser): Add support for using TypeScript, with moo as lexer base

    @eemeli
    eemeli committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    43dbf72 View commit details
    Browse the repository at this point in the history

  2. feat(parser): Add new implementation

    @eemeli
    eemeli committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    7e5385c View commit details
    Browse the repository at this point in the history

  3. docs(parser): Update README & API docs

    @eemeli
    eemeli committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    9b79382 View commit details
    Browse the repository at this point in the history

  4. feat(parser): Replace parser with new implementation 

    BREAKING CHANGE: The parser is completely rewritten in TypeScript. The
new implementation uses `moo` to create a lexer, rather than PEG.js.
During this change, the AST output changes slightly:
- Static strings are wrapped in a { type: 'content', value: string }
  token, rather than plain strings.
- Each token includes a `ctx` object, with information about its source
  context.
- For plural & selectordinal tokens, the offset is renamed as
  `pluralOffset`.
- Some of the errors change; braces with contents that are not
  MessageFormat are mostly parsed without error.
- The TypeScript types are slightly refactored, as they're no longer
  manually maintained.
    @eemeli
    eemeli committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    b2e9b78 View commit details
    Browse the repository at this point in the history

  5. feat(messageformat): Adjustments for parser API changes

    @eemeli
    eemeli committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    5e52f13 View commit details
    Browse the repository at this point in the history

  6. chore: Satisfy Prettier

    @eemeli
    eemeli committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    bcdf5b8 View commit details
    Browse the repository at this point in the history