-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reproducible engine build #271
Comments
Open
2 tasks
arnout
pushed a commit
to buildroot/buildroot
that referenced
this issue
Sep 29, 2023
There are many issues with this package: - The release tarballs from https://github.com/flutter/engine are in no state to compile. They are only for the use of gclient to download a source directory structure suitable to build the Flutter engine! If you download, extract and attempt to run `./tools/gn --no-goma --no-prebuilt-dart-sdk`, you receive the error message: `No such file or directory: 'flutter/flutter/third_party/gn/gn.' But wait! Wasn't the gn binary just called? No, that's a wrapper in the Flutter source tree that formats arguments to call the real gn binary. The real gn is not provided in the tarball but is downloaded via gclient (among many other supporting repositories.) Even worse, the flutter buildsystem depends on the .git dirs being present. (meta-flutter/meta-flutter#271) This dependency means it is not possible to create a reproducible tarball from the downloaded sources, which is why there is no .hash file provided. I have asked the flutter project to release full tarballs suitable for compiling here: flutter/flutter#130734 - Flutter engine includes a patched copy of clang that must be used to compile. Using a Buildroot-build clang results in linking warning and errors. As such, we depend on LLVM_ARCH_SUPPORTS but use the included clang for building. On the plus side, this saves time having to compile clang. - flutter-engine relies on the "PUB_CACHE", that is provided by flutter-sdk, so we need a build dependency, even if no tool from host-flutter-sdk-bin is used to build flutter-engine Tested with: - Debian 11 and 12 - Ubuntu 18.04, 20.04, and 22.04 - Fedora 38 - Per-package directories Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com> [yann.morin.1998@free.fr: - search gclient.py from PATH - indent shell script with 4 spaces - reorganise schell script with prepare/cleanup - tweak comment about weirdness of flutter buildsystem - use suitable-extactor and TAR_OPTIONS - use FLUTTER_SDK_BIN_PUB_CACHE - add dependency to host-futter-sdk-bin (Adam) ] Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Requirement is to support a reproducible engine library.
This means the file can be compared to prior build, and there is not difference.
The solution revolves around removal of .git folders and any processes dependent on the .git folder.
Round 1
It fails with
I update
flutter/build/git_revision.py
to return value of the engine I just pulled:./flutter/tools/gn --unoptimized --no-goma
returns without error.Build attempt fails with:
More later
The text was updated successfully, but these errors were encountered: