Make sure NativeQueryEditor doesn't crash if ace isn't available. Was…

… causing integration test failure
metabase · Mar 21, 2018 · 20846dd · 20846dd
1 parent febe98b
commit 20846dd
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/frontend/src/metabase/query_builder/components/NativeQueryEditor.jsx b/frontend/src/metabase/query_builder/components/NativeQueryEditor.jsx
@@ -178,7 +178,13 @@ export default class NativeQueryEditor extends Component {
     const { query } = this.props;
 
     let editorElement = ReactDOM.findDOMNode(this.refs.editor);
+
     // $FlowFixMe
+    if (typeof ace === "undefined" || !ace || !ace.edit) {
+      // fail gracefully-ish if ace isn't available, e.x. in integration tests
+      return;
+    }
+
     this._editor = ace.edit(editorElement);
 
     // listen to onChange events