Skip to content

Commit

Permalink
Add repro for #15714 (#15722)
Browse files Browse the repository at this point in the history
  • Loading branch information
nemanjaglumac committed Apr 21, 2021
1 parent e01bebc commit 22d4641
Showing 1 changed file with 20 additions and 0 deletions.
20 changes: 20 additions & 0 deletions frontend/test/metabase-db/postgres/custom-column.cy.spec.js
Expand Up @@ -75,4 +75,24 @@ describe("postgres > question > custom columns", () => {
cy.contains(ESCAPED_REGEX);
});
});

it.skip("`Percentile` custom expression function should accept two parameters (metabase#15714)", () => {
cy.visit("/question/new");
cy.findByText("Custom question").click();
cy.findByText(PG_DB_NAME).click();
cy.findByText("Orders").click();
cy.icon("add_data").click();
cy.get("[contenteditable='true']")
.click()
.type("Percentile([Subtotal], 0.1)");
cy.findByPlaceholderText("Something nice and descriptive")
.as("description")
.click();
cy.findByText("Function Percentile expects 1 argument").should("not.exist");
cy.get("@description").type("A");
cy.findByRole("button", { name: "Done" })
.should("not.be.disabled")
.click();
// Todo: Add positive assertions once this is fixed
});
});

0 comments on commit 22d4641

Please sign in to comment.