Skip to content

Commit

Permalink
[Target 43] Parse parameter and parameters_mapping on cards (#24501)
Browse files Browse the repository at this point in the history
* parse parameters and parameter_mapppings on card

* add a comment

Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com>
  • Loading branch information
qnkhuat and alxnddr committed Aug 3, 2022
1 parent cd0cd30 commit 7bc9fcc
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/metabase/models/card.clj
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,11 @@
:embedding_params :json
:query_type :keyword
:result_metadata ::result-metadata
:visualization_settings :visualization-settings})
:visualization_settings :visualization-settings
;; parameters and parameter_mappings are added in 44 but we have it
;; here to make sure it doesn't break if an user downgrades from 44 to 43 #(24497)
:parameters :parameters-list
:parameters_mappings :parameters-list})
:properties (constantly {:timestamped? true})
;; Make sure we normalize the query before calling `pre-update` or `pre-insert` because some of the
;; functions those fns call assume normalized queries
Expand Down

0 comments on commit 7bc9fcc

Please sign in to comment.