Skip to content

Commit

Permalink
Fix render error when removing a dashboard parameter
Browse files Browse the repository at this point in the history
  • Loading branch information
daltojohnso committed Feb 27, 2021
1 parent 8d5dd19 commit 989a9ec
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion frontend/src/metabase/dashboard/components/Dashboard.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,10 @@ function Sidebars(props) {
<ParameterSidebar
parameter={parameter}
otherParameters={otherParameters}
remove={() => removeParameter(editingParameterId)}
remove={() => {
setEditingParameter(null);
removeParameter(editingParameterId);
}}
done={() => setEditingParameter(null)}
showAddParameterPopover={showAddParameterPopover}
setParameter={setParameter}
Expand Down

0 comments on commit 989a9ec

Please sign in to comment.