Fix Embedded dashboard parameters parse runtime error (#41545)

* Fix parameters parse * Add e2e test * Add e2e test
metabase · Apr 18, 2024 · 9f88571 · 9f88571
1 parent dd1b41a
commit 9f88571
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 1 deletion.
diff --git a/e2e/test/scenarios/sharing/public-dashboard.cy.spec.js b/e2e/test/scenarios/sharing/public-dashboard.cy.spec.js
@@ -245,4 +245,16 @@ describe("scenarios > public > dashboard", () => {
 
     assertDashboardFullWidth();
   });
+
+  it("should render when a filter passed with value starting from '0' (metabase#41483)", () => {
+    cy.get("@dashboardId").then(id => {
+      visitPublicDashboard(id, {
+        params: { text: "002" },
+      });
+    });
+
+    cy.url().should("include", "text=002");
+
+    filterWidget().findByText("002").should("be.visible");
+  });
 });
diff --git a/frontend/src/metabase/lib/browser.js b/frontend/src/metabase/lib/browser.js
@@ -1,13 +1,15 @@
 import querystring from "querystring";
 
+import { safeJsonParse } from "metabase/lib/utils";
+
 function parseQueryStringOptions(s) {
   const options = querystring.parse(s);
 
   for (const name in options) {
     if (options[name] === "") {
       options[name] = true;
     } else if (/^(true|false|-?\d+(\.\d+)?)$/.test(options[name])) {
-      options[name] = JSON.parse(options[name]);
+      options[name] = safeJsonParse(options[name]);
     }
   }
 

diff --git a/frontend/src/metabase/lib/utils.ts b/frontend/src/metabase/lib/utils.ts
@@ -209,3 +209,16 @@ export function compareVersions(
 }
 
 export const isEEBuild = () => PLUGIN_IS_EE_BUILD.isEEBuild();
+
+export const safeJsonParse = (value: string | null | undefined) => {
+  if (!value) {
+    return null;
+  }
+
+  try {
+    return JSON.parse(value);
+  } catch (e) {
+    console.error("Unable to parse JSON: ", value, e);
+    return null;
+  }
+};
diff --git a/frontend/src/metabase/public/containers/PublicDashboard/PublicDashboard.unit.spec.tsx b/frontend/src/metabase/public/containers/PublicDashboard/PublicDashboard.unit.spec.tsx
@@ -70,6 +70,16 @@ describe("PublicDashboard", () => {
 
     expect(firstTab).toHaveAttribute("aria-selected", "true");
   });
+
+  it("should render when a filter passed with value starting from '0' (metabase#41483)", async () => {
+    // note: as all slugs this is ignored and we only use the id
+    await setup({
+      queryString: "?my-filter-value=01",
+    });
+
+    // should not throw runtime error and render dashboard content
+    expect(screen.getByText(DASHBOARD_TITLE)).toBeInTheDocument();
+  });
 });
 
 async function setup({