-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
馃 backported "Fix column scaling ("Multiply by a number") bugs" (#43690)
* Fix column scaling ("Multiply by a number") bugs (#43668) * return empty string so non-empty labels do not get hidden by empty labels * fix function name * apply scaling in transformed dataset * add missing option to OptionsType * fix double scaling * add column scaling to waterfall transformed dataset * add column value scaling to dataset transform * fix stacked bar segment labels not responding to column scaling * fix tooltip values displayed * since scaling as added to transformedDataset, use transformedDataset for formatters * revert changes to display percentage instead of absolute value * fix stacked data labels * add loki variant for custom y-axis range with column scaling * fix stack segmented label formatters compact calculation * scale original dataset and use that instead of modifying transformedDataset * update loki snapshots * fix scatter plot dataset scaling * fix tooltip values being double scaled * add E2E test to validate behavior * add helper for not duplicating the column scaling * port multiple y-axis metrics with column scaling fixes to RowChart * add waterfall and scatterplot loki variants * fix type errors and failing unit tests * fix failing unit tests * update loki snapshots * update loki snapshots --------- Co-authored-by: Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
- Loading branch information
1 parent
e236774
commit a1e1e60
Showing
56 changed files
with
1,313 additions
and
49 deletions.
There are no files selected for viewing
Binary file modified
BIN
-1.03 KB
(93%)
...i/reference/chrome_laptop_static_viz_ComboChart_Bar_Auto_Formatting_Compact.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.22 KB
(92%)
.loki/reference/chrome_laptop_static_viz_ComboChart_Bar_Auto_Formatting_Full.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.72 KB
(90%)
.loki/reference/chrome_laptop_static_viz_ComboChart_Bar_Formatting_Full.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-596 Bytes
(98%)
...ence/chrome_laptop_static_viz_ComboChart_Bar_Stacked_Total_Formatted_Values.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+15.4 KB
...chrome_laptop_static_viz_ComboChart_Custom_Y_Axis_Range_With_Column_Scaling.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-967 Bytes
(93%)
...ence/chrome_laptop_static_viz_ComboChart_Y_Axis_Compact_Without_Data_Labels.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3 Bytes
(100%)
...nce/chrome_laptop_static_viz_ScatterPlot_Auto_Y_Axis_Exclude_Zero_With_Goal.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-32 Bytes
(100%)
.loki/reference/chrome_laptop_static_viz_ScatterPlot_Bubble_Size.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+44 Bytes
(100%)
.loki/reference/chrome_laptop_static_viz_ScatterPlot_Custom_Y_Axis_Range.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.5 KB
...hrome_laptop_static_viz_ScatterPlot_Custom_Y_Axis_Range_With_Column_Scaling.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+19 Bytes
(100%)
.loki/reference/chrome_laptop_static_viz_ScatterPlot_Default.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-73 Bytes
(100%)
.loki/reference/chrome_laptop_static_viz_ScatterPlot_Goal_Line.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+81 Bytes
(100%)
.loki/reference/chrome_laptop_static_viz_ScatterPlot_Histogram_X_Scale.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-9 Bytes
(100%)
.loki/reference/chrome_laptop_static_viz_ScatterPlot_Log_X_Scale.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-40 Bytes
(100%)
.loki/reference/chrome_laptop_static_viz_ScatterPlot_Log_X_Scale_At_One.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-23 Bytes
(100%)
.loki/reference/chrome_laptop_static_viz_ScatterPlot_Multi_Dimension_Breakout.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-23 Bytes
(100%)
...e/chrome_laptop_static_viz_ScatterPlot_Multi_Dimension_Breakout_Bubble_Size.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-19 Bytes
(100%)
.loki/reference/chrome_laptop_static_viz_ScatterPlot_Multi_Metric_Series.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+104 Bytes
(100%)
.loki/reference/chrome_laptop_static_viz_ScatterPlot_Ordinal_X_Scale.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+19 Bytes
(100%)
.loki/reference/chrome_laptop_static_viz_ScatterPlot_Power_X_Scale.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+4 Bytes
(100%)
...i/reference/chrome_laptop_static_viz_ScatterPlot_Power_X_Scale_Multi_Series.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+123 Bytes
(100%)
.loki/reference/chrome_laptop_static_viz_ScatterPlot_Timeseries_X_Scale.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.1 KB
...me_laptop_static_viz_WaterfallChart_Custom_Y_Axis_Range_With_Column_Scaling.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-701 Bytes
(97%)
...rence/chrome_laptop_static_viz_WaterfallChart_Data_Labels_Column_Formatting.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.