Skip to content

Commit

Permalink
Don't throw when sent non-int limit/offset
Browse files Browse the repository at this point in the history
This middleware shouldn't throw exceptions when `limit` or `offset`
query parametesr aren't integers.
  • Loading branch information
johnswanson committed Apr 1, 2024
1 parent 6655faa commit d4582c1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/metabase/server/middleware/offset_paging.clj
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
(or page limit offset))

(defn- parse-paging-params [{{:strs [limit offset]} :query-params}]
(let [limit (or (some-> limit Integer/parseUnsignedInt)
(let [limit (or (some-> limit parse-long)
default-limit)
offset (or (some-> offset Integer/parseUnsignedInt)
offset (or (some-> offset parse-long)
default-offset)]
{:limit limit, :offset offset}))

Expand Down

0 comments on commit d4582c1

Please sign in to comment.