type updates

metabase · May 10, 2024 · ecbdc46 · ecbdc46
1 parent 88fea12
commit ecbdc46
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/frontend/src/metabase-types/api/activity.ts b/frontend/src/metabase-types/api/activity.ts
@@ -14,6 +14,7 @@ export interface BaseRecentItem {
   id: number;
   name: string;
   model: ActivityModel;
+  description?: string | null;
   timestamp: string;
 }
 

diff --git a/frontend/src/metabase-types/api/dashboard.ts b/frontend/src/metabase-types/api/dashboard.ts
@@ -184,7 +184,7 @@ export type UnrestrictedLinkEntity = {
   model: SearchModel;
   name: string;
   display_name?: string;
-  description?: string;
+  description?: string | null;
   display?: CardDisplayType;
 };
 

diff --git a/frontend/src/metabase/lib/urls/modelToUrl.unit.spec.ts b/frontend/src/metabase/lib/urls/modelToUrl.unit.spec.ts
@@ -83,6 +83,6 @@ describe("urls > modelToUrl", () => {
         },
         timestamp: "2021-01-01T00:00:00.000Z",
       }),
-    ).toBe("/question#?db=22&table=33");
+    ).toBe("/question/#?db=22&table=33");
   });
 });
diff --git a/frontend/src/metabase/palette/hooks/useCommandPalette.tsx b/frontend/src/metabase/palette/hooks/useCommandPalette.tsx
@@ -213,7 +213,7 @@ export const useCommandPalette = () => {
         extra:
           item.model === "table"
             ? {
-                database: item.model_object.database_name,
+                database: item.database.name,
                 href: Urls.modelToUrl(item),
               }
             : {