Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter popovers are getting clipped at the top in the notebook #10448

Closed
mazameli opened this issue Jul 31, 2019 · 1 comment
Closed

Filter popovers are getting clipped at the top in the notebook #10448

mazameli opened this issue Jul 31, 2019 · 1 comment
Assignees
@tlrobinson
Labels
Difficulty:Easy .Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Type:Bug Product defects
Projects
0.33 final fixes and polish Bug Bashing Bonanza
Milestone
0.33

Comments

@mazameli
Copy link
Contributor

The popover also won't scroll. Calling this a p1 since it's very easy to run into on a laptop, and makes it really annoying or impossible to try and filter in this first step.

image
@mazameli mazameli added Type:Bug Product defects Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Query Builder labels Jul 31, 2019
@mazameli mazameli added this to the 0.33 milestone Jul 31, 2019
@mazameli mazameli moved this from To do to Release blockers in 0.33 final fixes and polish Aug 5, 2019
@tlrobinson tlrobinson moved this from Release blockers to In progress in 0.33 final fixes and polish Aug 5, 2019
@tlrobinson tlrobinson self-assigned this Aug 5, 2019
@salsakran salsakran added this to P1 Bugs in Bug Bashing Bonanza Aug 5, 2019
tlrobinson added a commit that referenced this issue Aug 5, 2019
@tlrobinson
Misc layout polish. Resolves #10448
269402b
@tlrobinson tlrobinson moved this from In progress to Needs Review in 0.33 final fixes and polish Aug 6, 2019
@tlrobinson tlrobinson mentioned this issue Aug 6, 2019
Merged
tlrobinson added a commit that referenced this issue Aug 7, 2019
@tlrobinson
Misc layout polish + table performance (#10497)
d1daa52 
* Misc layout polish. Resolves #10448

* Improve table scrolling performance

* Fix double scroll issue in data selector

* Flow

* Fix button snapshot test

* Fix e2e test

* comments
@tlrobinson tlrobinson moved this from Needs Review to Done in 0.33 final fixes and polish Aug 7, 2019
@mazameli
Copy link
Contributor Author

mazameli commented Aug 9, 2019

Fixed by #10497

@mazameli mazameli closed this as completed Aug 9, 2019
@mazameli mazameli mentioned this issue Aug 9, 2019
Closed
@mazameli mazameli moved this from P1 Bugs to Done in Bug Bashing Bonanza Aug 15, 2019
@nemanjaglumac nemanjaglumac mentioned this issue Jan 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlrobinson tlrobinson

Labels
Difficulty:Easy .Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Type:Bug Product defects
Projects
No open projects
0.33 final fixes and polish
  
Done
Bug Bashing Bonanza
  
Done
Milestone
0.33
Development

No branches or pull requests
2 participants
@tlrobinson @mazameli