Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly joined fields should be prefixed with join alias, which should be set to foreign key display_name by default #10550

Closed
2 tasks done
tlrobinson opened this issue Aug 10, 2019 · 2 comments
Closed
2 tasks done

Explicitly joined fields should be prefixed with join alias, which should be set to foreign key display_name by default #10550

tlrobinson opened this issue Aug 10, 2019 · 2 comments
Assignees
@tlrobinson
Labels
.Frontend Priority:P2 Average run of the mill bug Type:Bug Product defects
Projects
0.33 final fixes and polish
Milestone
0.33

Comments

@tlrobinson
Copy link
Contributor

tlrobinson commented Aug 10, 2019 •
edited

Similar to #10549

  • backend: columns from a joined-field should be prefixed with the join alias instead of the table name
  • frontend: join alias should be set to the foreign key field's display_name with trailing "id" removed

Screen Shot 2019-08-09 at 4 42 53 PM
@tlrobinson tlrobinson added Type:Bug Product defects Priority:P2 Average run of the mill bug .Frontend .Backend labels Aug 10, 2019
@tlrobinson tlrobinson added this to the 0.33 milestone Aug 10, 2019
@tlrobinson tlrobinson mentioned this issue Aug 10, 2019
Open
2 tasks
@tlrobinson tlrobinson moved this from To do to Release blockers in 0.33 final fixes and polish Aug 12, 2019
@tlrobinson tlrobinson moved this from Release blockers to In progress in 0.33 final fixes and polish Aug 13, 2019
@tlrobinson tlrobinson mentioned this issue Aug 13, 2019
Merged
@camsaul
Copy link
Member

camsaul commented Aug 13, 2019

Backend implemented by #10564

@camsaul camsaul removed their assignment Aug 13, 2019
@camsaul camsaul removed the .Backend label Aug 13, 2019
@tlrobinson tlrobinson moved this from In progress to Needs Review in 0.33 final fixes and polish Aug 13, 2019
@mazameli
Copy link
Contributor

Fixed by #10531 and #10564

@mazameli mazameli moved this from Needs Review to Done in 0.33 final fixes and polish Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlrobinson tlrobinson

Labels
.Frontend Priority:P2 Average run of the mill bug Type:Bug Product defects
Projects
No open projects
0.33 final fixes and polish
  
Done
Milestone
0.33
Development

No branches or pull requests
3 participants
@tlrobinson @camsaul @mazameli