Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendly Column names not shown anymore #10819

Closed
gvisniuc opened this issue Sep 6, 2019 · 7 comments
Closed

Friendly Column names not shown anymore #10819

gvisniuc opened this issue Sep 6, 2019 · 7 comments
Labels
Priority:P2 Average run of the mill bug Querying/Native The SQL/native query editor Type:Bug Product defects

Comments

@gvisniuc
Copy link

gvisniuc commented Sep 6, 2019

Hi there,

I’m currently running Metabase v0.33.1 and have noticed that the column names declared as aliases in SQL (i.e. “my_column”) are not following the FRIENDLY TABLE AND FIELD NAMES setting anymore, and do not replace underscores with spaces.

I tried finding any issues or traces of this change as well, so I’m not sure if this is a bug or intended behaviour.

7b616e6b1d8e1a943dd8b2a2836cc67f16a8009e

Your browser and the version: Chrome 76.x
Your operating system: macOS Mojave
Your databases: Redshift
Metabase version: 0.33.1
Metabase hosting environment: Official Metabase Docker image running in Kubernetes.
Metabase internal database: AWS RDS Postgres

⬇️ Please click the 👍 reaction instead of leaving a +1 or 👍 comment

@gvisniuc gvisniuc added the Type:Bug Product defects label Sep 6, 2019
@flamber
Copy link
Contributor

flamber commented Sep 6, 2019

Pinging @camsaul because of PR #10196, but I cannot find the reason behind it.

@gvisniuc
Copy link
Author

gvisniuc commented Sep 10, 2019

Also just a small note even when declaring a title case alias such as select field as "My Alias" the column names will be transformed to lowercase as well "my alias".

@salsakran
Copy link
Contributor

The intended behavior is that we respect your aliases and don't mess with them, since the friendly names was misfiring more often than not with raw sql.

The lowercasing is a bug and marking it as such

@salsakran salsakran added Priority:P2 Average run of the mill bug Querying/Native The SQL/native query editor labels Oct 6, 2019
@ismayil22
Copy link

ismayil22 commented Oct 7, 2019

Guys Hi,

I have related question regarding column names, but not sure is it bug or should work like intended. Since you removed "friendly column names", as I see in v0.33.3, I had to fix all column names using "Settings->Table options->Column title.

Thus adjusted column names as needed. Problem is that they do not reflect on Pulses now (see second screenshot). It seems it is bug , and they should be adjusted on Pulses too. Am I right?

image

Second screenshot:
image

@ismayil22
Copy link

@flamber Hi, can you please give me approx. time when above issue will be fixed (I hope).
1 week? 1 month? 1 year?

Or maybe easier just revert above mentioned by you PR :) #10819 (comment)

All Pulses now looks weird, and it will take eternity to fix all these column names manually in all existing pulses.

@flamber
Copy link
Contributor

flamber commented Oct 11, 2019

@ismayil22 Did you see the comment by @salsakran? I don't think this will be reverted. The lower-casing is a bug, but cannot give you a time-frame, there's 2000 other open issues.
Pulses doesn't read the formatting from the visualization, which is why the column name doesn't change in the pulse, when you edit it in table options - there's an issue open on that #8258.

@walterl
Copy link
Contributor

walterl commented Mar 13, 2020

I'm not seeing the lower-casing issue on current master (0.35.0-RC @ fb1ed0d):

image

Closing, since it appears to have been fixed already.

@walterl walterl closed this as completed Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:P2 Average run of the mill bug Querying/Native The SQL/native query editor Type:Bug Product defects
Projects
None yet
Development

No branches or pull requests

5 participants