Between Dates filter behaves inconsistently based on whether the column is from a joined table or not

[scottbradybuckii]

Describe the bug
When adding a date filter between two dates (I am currently using Postgres), it will make the filter inclusive of the end date if the column is from the base table, but it will make it exclusive of the end date if the column is from a joined table.

Logs
No errors are generated

To Reproduce
Steps to reproduce the behavior:

1. Add a date filter to a column on the base table of a Question that is between two dates
2. Click on the "View the SQL" button for that Question
3. Verify that the dates are inclusive - ie. if your filter is between 2020-07-06 -> 2020-07-08, then the query would looks something like:
   WHERE ("public"."line_items"."created_at" >= timestamp with time zone '2020-07-06 00:00:00.000Z' AND "public"."line_items"."created_at" < timestamp with time zone '2020-07-09 00:00:00.000Z')
4. Add a join to the Question
5. Change the same date filter to filter down based on a date column in the joined table
6. Click on the "View the SQL" button for that Question
7. Verify that the dates are now exclusive:
   WHERE "Transaction"."created_at" BETWEEN timestamp with time zone '2020-07-06 00:00:00.000Z' AND timestamp with time zone '2020-07-08 00:00:00.000Z'

Expected behavior
The inclusivity and exclusivity shouldn't change based on whether you are filtering a column from a base table or joined table

Screenshots
Inclusive from base table:

Exclusive from joined table:

Information about your Metabase Installation:

• Your browser and the version: Chromium 81.0.4044.138
• Your operating system: Manjaro
• Your databases: Postgres
• Metabase version: v0.35.4
• Metabase hosting environment: Docker running on Ubuntu 16.04
• Metabase internal database: H2

Severity
Moderately severe. We have been using Metabase for over a year now and just noticed it, but it is worrisome because we are putting together weekly financial reports and this off-by-one day error has messed up our reporting. We can train users to add an extra day to reports that are filtering based on a joined date, but if this bug gets fixed, then those reports will be off by a day.

[flamber]

I have a feeling that it's related to #10824 (and perhaps #11837).

Steps to reproduce

1. Custom question > Sample Dataset > Products
2. Join Products (let's call it JoinedProducts) again on ID = ID
3. Filter by Products.CreatedAt between 04/15/2019-04/15/2019 - this will result in 1 row
4. Filter by JoinedProducts.CreatedAt between 04/15/2019-04/15/2019 - this will result in 0 rows
5. Summarize Count
   
6. Expected result 1, but getting 0

SELECT count(*) AS "count"
FROM "PUBLIC"."PRODUCTS"
LEFT JOIN "PUBLIC"."PRODUCTS" "Products" ON "PUBLIC"."PRODUCTS"."ID" = "Products"."ID"
WHERE (("PUBLIC"."PRODUCTS"."CREATED_AT" >= timestamp with time zone '2019-04-15 00:00:00.000+02:00'
   AND "PUBLIC"."PRODUCTS"."CREATED_AT" < timestamp with time zone '2019-04-16 00:00:00.000+02:00')
AND "Products"."CREATED_AT" BETWEEN timestamp with time zone '2019-04-15 00:00:00.000+02:00' AND timestamp with time zone '2019-04-15 00:00:00.000+02:00')

[nemanjaglumac]

@camsaul since you're assigned to work on this issue, just a note that a repro has been made, and it should be unskipped and merged together with a fix.

[camsaul]

Fixed by #13991