Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.37-RC2: disable Done button in cases where click behavior target isn't specified #13413

Closed
mazameli opened this issue Oct 8, 2020 · 0 comments · Fixed by #13424
Closed

Comments

@mazameli
Copy link
Contributor

mazameli commented Oct 8, 2020

Related to #13405, we should be smarter about preventing users from clicking Done in cases where they are in fact not done.

Cross filtering

Done should be disabled here until you pick a target parameter; this behavior doesn't do anything otherwise.

image

URLs

We should probably add a Cancel button here, and at least disable Done until it has something in it:

image

Making the above changes to the modal should in theory prevent this state, but Done should be disabled in this state where my URL is blank:

image

Saved question/dashboard as destination

We should disable Done if no question/dashboard has been selected:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants