Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking Visualize in Notebook makes the question "dirty" even if no changes was made #13470

Closed
flamber opened this issue Oct 14, 2020 · 1 comment · Fixed by #16980
Closed

Clicking Visualize in Notebook makes the question "dirty" even if no changes was made #13470

flamber opened this issue Oct 14, 2020 · 1 comment · Fixed by #16980
Assignees
@jeff-bruemmer
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Notebook Items specific to the Custom/Notebook query builder .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.40.1

Comments

@flamber
Copy link
Contributor

flamber commented Oct 14, 2020

Describe the bug
When clicking Visualize in Notebook editor, on an existing question, then the state gets "dirty" showing the possibility to "Save" the question, even though there isn't any changes.

To Reproduce
Steps to reproduce the behavior:

  1. Simple question > Sample Dataset > Orders - save question
    image
  2. Click Notebook-editor (top-right), without making any changes, click Visualize
  3. Now the question state is "dirty", with the option to save the question, but no new results are requested, so it's just the frontend state which is set to "dirty". If there were changes to the question, then it would also request POST /api/dataset.
    image

Expected behavior
Only set question to "dirty" if there has been changes to the question.

Information about your Metabase Installation:
Metabase 0.35.0, 0.36.7, 0.37.0-rc2

Additional context
Related to #11994
@flamber flamber added Type:Bug Product defects Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Frontend Querying/Notebook Items specific to the Custom/Notebook query builder labels Oct 14, 2020
@nemanjaglumac nemanjaglumac mentioned this issue Oct 16, 2020
Merged
nemanjaglumac added a commit that referenced this issue Oct 16, 2020
@nemanjaglumac
Add repro for #13470
ff0f09f
nemanjaglumac added a commit that referenced this issue Oct 16, 2020
@nemanjaglumac
Add repro for #13470 (#13506)
fc4be09
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Oct 23, 2020
@robdaemon robdaemon assigned robdaemon and unassigned robdaemon Oct 27, 2020
@jeff-bruemmer jeff-bruemmer self-assigned this Jul 12, 2021
@jeff-bruemmer jeff-bruemmer mentioned this issue Jul 12, 2021
Merged
@jeff-bruemmer
Copy link
Member

Fixed by #16980.

@flamber flamber added this to the 0.40.1 milestone Jul 12, 2021
@jeff-bruemmer jeff-bruemmer linked a pull request Jul 12, 2021 that will close this issue
In notebook: clicking Visualize should only offer to save question if there are changes #16980
Merged
@deploysentinel deploysentinel bot mentioned this issue Nov 28, 2022
Merged
@deploysentinel deploysentinel bot mentioned this issue Jan 27, 2023
Merged
This was referenced Mar 25, 2023
Merged
Merged
@deploysentinel deploysentinel bot mentioned this issue Apr 26, 2023
Merged
1 task
@deploysentinel deploysentinel bot mentioned this issue Aug 9, 2023
Merged
This was referenced Aug 30, 2023
Merged
Merged
This was referenced Sep 8, 2023
Merged
Closed
This was referenced Oct 10, 2023
Merged
Closed
@deploysentinel deploysentinel bot mentioned this issue Oct 19, 2023
Merged
This was referenced Feb 5, 2024
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
@replay-io replay-io bot mentioned this issue Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeff-bruemmer jeff-bruemmer

Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Notebook Items specific to the Custom/Notebook query builder .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.40.1
4 participants
@robdaemon @flamber @jeff-bruemmer @nemanjaglumac