Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling doesnt update dragging on Visible Column configuration #14238

Closed
Tracked by #32517
ishwi opened this issue Jan 4, 2021 · 3 comments · Fixed by #34844
Closed
Tracked by #32517

Scrolling doesnt update dragging on Visible Column configuration #14238

ishwi opened this issue Jan 4, 2021 · 3 comments · Fixed by #34844
Assignees
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Type:Bug Product defects Visualization/Chart Settings Visualization/Tables Raw, summarized, and pivoted tables
Milestone

Comments

@ishwi
Copy link

ishwi commented Jan 4, 2021

Describe the bug
Scroll doesnt behave properly when you try to move a column of the visible column list in the table view configuration.
Happens when there are more columns than fit on a screen so there is a scroll.

Logs
Not relevant

To Reproduce
Steps to reproduce the behavior:

  1. Go to a question with a visualization type of Table.
  2. Press the configuration option
  3. On the Visible Column option, Hold and try to drag one column.
  4. While dragging it, scroll the page to try to go down or up. The dragged option will move while dragged, but the destination when you drop doesn't update at all.

Expected behavior
When you scroll the destination should be updated with the scroll

Screenshots
If applicable, add screenshots to help explain your problem.

Information about your Metabase Installation:

{
  "browser-info": {
    "language": "en",
    "platform": "Win32",
    "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.88 Safari/537.36",
    "vendor": "Google Inc."
  },
  "system-info": {
    "file.encoding": "UTF-8",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "11.0.7+10",
    "java.vendor": "AdoptOpenJDK",
    "java.vendor.url": "https://adoptopenjdk.net/",
    "java.version": "11.0.7",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "11.0.7+10",
    "os.name": "Linux",
    "os.version": "5.7.0-0.bpo.2-cloud-amd64",
    "user.language": "en",
    "user.timezone": "GMT"
  },
  "metabase-info": {
    "databases": [
      "postgres",
      "h2"
    ],
    "hosting-env": "unknown",
    "application-database": "postgres",
    "application-database-details": {
      "database": {
        "name": "PostgreSQL",
        "version": "12.1"
      },
      "jdbc-driver": {
        "name": "PostgreSQL JDBC Driver",
        "version": "42.2.8"
      }
    },
    "run-mode": "prod",
    "version": {
      "date": "2020-12-17",
      "tag": "v0.37.4",
      "branch": "release-x.37.x",
      "hash": "e0d5287"
    },
    "settings": {
      "report-timezone": null
    }
  }
}

Severity
How severe an issue is this bug to you? Is this annoying, blocking some users, blocking an upgrade or blocking your usage of Metabase entirely?
Its annoying becuase it makes the sorting of the columns an annoying task.

Additional context

metabase.mp4
@ishwi ishwi added .Needs Triage Type:Bug Product defects labels Jan 4, 2021
@flamber flamber added Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Visualization/Chart Settings Visualization/Tables Raw, summarized, and pivoted tables and removed .Needs Triage labels Jan 24, 2021
@flamber
Copy link
Contributor

flamber commented Jan 24, 2021

Related to #10460 #12870 #12494 and #3266

@npfitz
Copy link
Contributor

npfitz commented Oct 19, 2023

This will be addressed by fixing the dragging scroll that happens when you bring a column towards the bottom of the list. It isn't working properly now, but when it is working, it will also disable being able to use your scroll wheel while dragging

@npfitz
Copy link
Contributor

npfitz commented Oct 30, 2023

This was actually included in 0.47.6, but I'm adding it in 47.7 so that it's included in release notes

This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Type:Bug Product defects Visualization/Chart Settings Visualization/Tables Raw, summarized, and pivoted tables
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants