Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableInteractive - migrate DimensionInfoPopover from legacy query #37585

Merged
merged 24 commits into from
Jan 12, 2024

Conversation

ranquild
Copy link
Contributor

@ranquild ranquild commented Jan 11, 2024

Partially addresses #37527

  • Rename DimensionInfo to FieldInfo
  • Make it work for DatasetColumn, they have the same properties as Field class that was used before
  • Field is still passed in Data reference pages so we need to support both
  • I didn't do any cleanup in these components; minimal changes only

@ranquild ranquild self-assigned this Jan 11, 2024
@metabase-bot metabase-bot bot added .Team/QueryingComponents visual Run Percy visual testing labels Jan 11, 2024
Copy link

github-actions bot commented Jan 11, 2024

Codenotify: Notifying subscribers in CODENOTIFY files for diff bcd4448...5f983ce.

Notify File(s)
@alxnddr frontend/src/metabase/visualizations/components/TableInteractive/TableInteractive.jsx
frontend/src/metabase/visualizations/lib/table.js
frontend/src/metabase/visualizations/visualizations/Table.jsx

@ranquild ranquild added the no-backport Do not backport this PR to any branch label Jan 11, 2024
@ranquild ranquild changed the title [WIP] Migrate TableInteractive from legacy query Migrate TableInteractive from legacy query Jan 11, 2024
@ranquild ranquild requested a review from a team January 11, 2024 17:54
@ranquild ranquild changed the title Migrate TableInteractive from legacy query Migrate TableInteractive -> DimensionInfoPopover from legacy query Jan 11, 2024
Copy link

replay-io bot commented Jan 11, 2024

StatusComplete ↗︎
Commit227d6d6
Results
⚠️ 3 Flaky
  • should allow users to provide internal urls
      Timed out retrying after 4000ms: expected 'http://localhost:4000/' to equal 'http://localhost:4000/test-1'
  • should be able to run update and delete actions when enabled for a admin user
      Timed out retrying after 4000ms: expected '<input#6.emotion-1vwd982.edcfyzd5>' to have value '2024-01-12T03:41:00', but the value was '2024-01-12T03:41'
  • with CountIf
2200 Passed

@ranquild ranquild enabled auto-merge (squash) January 12, 2024 10:00
@ranquild ranquild changed the title Migrate TableInteractive -> DimensionInfoPopover from legacy query TableInteractive - migrate DimensionInfoPopover from legacy query Jan 12, 2024
@ranquild ranquild merged commit cae348a into master Jan 12, 2024
106 checks passed
@ranquild ranquild deleted the table-dimension-popover branch January 12, 2024 12:00
Copy link

@ranquild Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryingComponents visual Run Percy visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants