-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TableInteractive - migrate DimensionInfoPopover from legacy query #37585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codenotify: Notifying subscribers in CODENOTIFY files for diff bcd4448...5f983ce.
|
ranquild
changed the title
[WIP] Migrate TableInteractive from legacy query
Migrate TableInteractive from legacy query
Jan 11, 2024
ranquild
changed the title
Migrate TableInteractive from legacy query
Migrate TableInteractive -> DimensionInfoPopover from legacy query
Jan 11, 2024
|
kamilmielnik
approved these changes
Jan 12, 2024
ranquild
changed the title
Migrate TableInteractive -> DimensionInfoPopover from legacy query
TableInteractive - migrate DimensionInfoPopover from legacy query
Jan 12, 2024
@ranquild Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no-backport
Do not backport this PR to any branch
.Team/QueryingComponents
visual
Run Percy visual testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #37527
DimensionInfo
toFieldInfo
DatasetColumn
, they have the same properties asField
class that was used beforeField
is still passed inData reference
pages so we need to support both