Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: some results are as being in a folder which doesn't exist in the data reference #15216

Closed
brunobergher opened this issue Mar 18, 2021 · 3 comments · Fixed by #15230
Closed
Assignees
Labels
Organization/Search Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Type:Bug Product defects
Milestone

Comments

@brunobergher
Copy link
Contributor

To Reproduce

  1. Search for "orders"
  2. It shows up in this PUBLIC folder

Expected behavior
To be shown at the root of Sample Dataset

Screenshots
Example

Information about your Metabase Installation:
Bugbash version 80f984c

@brunobergher brunobergher added Type:Bug Product defects Priority:P2 Average run of the mill bug Organization/Search labels Mar 18, 2021
@flamber
Copy link
Contributor

flamber commented Mar 18, 2021

"PUBLIC" is the schema. The Sample Dataset only has one schema.
It should be shown, when there's more than one schema.

@brunobergher
Copy link
Contributor Author

There wasn't more than one schema in this case. The inconsistency is what is bothering me:

explore view

@kdoh
Copy link
Member

kdoh commented Mar 18, 2021

Yeah I think this is just a matter of us not reflecting the "if there's one schema, don't burden people with having to think about it" stance in the search context. Should be an easy tweak although I wish there was a more centralized place to keep that business logic to prevent this kind of accidental rendering difference.

@kdoh kdoh self-assigned this Mar 18, 2021
@kdoh kdoh added this to the 0.39 milestone Mar 18, 2021
@brunobergher brunobergher added Priority:P3 Cosmetic bugs, minor bugs with a clear workaround and removed Priority:P2 Average run of the mill bug labels Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Organization/Search Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants