Only display schema in search results if there is more than one schema #15230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15216
Uses
Schema.ListLoaderto look at the number of schemas for a database and only shows the schema for a table if there are multiple that we need to display. This keeps things consistent with how we show schemas elsewhere in the app.One unfortunate side effect of this is that there can be a brief "loading" spinner on individual items. I'm going to investigate setting
loadingAndErrorWrapperto false on the loader to prevent the UI flash.Todo
loadingAndErrorWrapperfromSchema.ListLoaderto prevent UI flash