Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waterfall visualization is not working with unaggregated data #15465

Closed
alxnddr opened this issue Apr 2, 2021 · 4 comments · Fixed by #17988
Closed

Waterfall visualization is not working with unaggregated data #15465

alxnddr opened this issue Apr 2, 2021 · 4 comments · Fixed by #17988
Assignees
@alxnddr
Labels
.Frontend Priority:P2 Average run of the mill bug .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/Charts Line, area, bar, combo, and scatter charts.
Milestone
0.41

Comments

@alxnddr
Copy link
Member

alxnddr commented Apr 2, 2021 •
edited by flamber
Loading

Describe the bug
Waterfall visualization is not working with unaggregated data

To Reproduce

  1. Run the following SQL
SELECT parsedatetime('2020-01-01', 'yyyy-MM-dd') AS "d", 1 AS "c" UNION ALL
SELECT parsedatetime('2020-01-01', 'yyyy-MM-dd') AS "d", 2 AS "c" UNION ALL
SELECT parsedatetime('2020-01-02', 'yyyy-MM-dd') AS "d", 3 AS "c"
  1. Select "Waterfall" visualization - blank
    image

Expected behavior
A waterfall chart is shown

Actual behavior
Visualization is not shown and there is an error in console: TypeError: Cannot read property 'data' of undefined
@flamber
Copy link
Contributor

flamber commented Apr 2, 2021 •
edited
Loading

Related to #15152

@alxnddr

This comment has been minimized.

Sign in to view
@flamber

This comment has been minimized.

Sign in to view
@alxnddr

This comment has been minimized.

Sign in to view
@flamber flamber added Visualization/Charts Line, area, bar, combo, and scatter charts. Priority:P2 Average run of the mill bug and removed .Needs Triage labels Apr 3, 2021
nemanjaglumac added a commit that referenced this issue Apr 23, 2021
@nemanjaglumac
Add repro for #15465
58c1588
@nemanjaglumac nemanjaglumac mentioned this issue Apr 23, 2021
Merged
nemanjaglumac added a commit that referenced this issue Apr 26, 2021
@nemanjaglumac
#15465 Repro: Waterfall visualization is not working with unaggregate…
0d0868b 
…d data (#15786)
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Apr 26, 2021
@alxnddr alxnddr self-assigned this Sep 21, 2021
@alxnddr alxnddr mentioned this issue Sep 21, 2021
Merged
@flamber flamber added this to the 0.41 milestone Sep 23, 2021
@deploysentinel deploysentinel bot mentioned this issue Dec 12, 2022
Merged
@deploysentinel deploysentinel bot mentioned this issue Jan 4, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Jan 13, 2023
Merged
This was referenced Feb 21, 2023
Merged
Merged
This was referenced Mar 1, 2023
Merged
Merged
Merged
@deploysentinel deploysentinel bot mentioned this issue Mar 23, 2023
Merged
This was referenced Oct 18, 2023
Merged
Merged
This was referenced Feb 5, 2024
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
@replay-io replay-io bot mentioned this issue Feb 13, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alxnddr alxnddr

Labels
.Frontend Priority:P2 Average run of the mill bug .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/Charts Line, area, bar, combo, and scatter charts.
Projects
None yet
Milestone
0.41
Development

Successfully merging a pull request may close this issue.

Handle unaggregated data warning for waterfall chart metabase/metabase
3 participants
@flamber @alxnddr @nemanjaglumac