Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialization dumps with static references instead of paths in 1.39.0 #15812

Closed
flamber opened this issue Apr 26, 2021 · 2 comments · Fixed by #15858
Closed

Serialization dumps with static references instead of paths in 1.39.0 #15812

flamber opened this issue Apr 26, 2021 · 2 comments · Fixed by #15858
Assignees
@jeff303
Labels
Operation/Serialization Enterprise contents migration Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Milestone
0.39.3

Comments

@flamber
Copy link
Contributor

flamber commented Apr 26, 2021

Describe the bug
Serialization does not handle the new field dimension(instead of field-id), so it fails to replace references during dump

To Reproduce

  1. Create a Simple question on the source like Orders: Sum of Total group by CreatedAt:Month
  2. Serialization dump - no errors reported
  3. The generated yaml looks like this with static ID references
...
dataset_query:
  type: query
  query:
    source-query:
      source-table: /databases/Sample Dataset/schemas/PUBLIC/tables/ORDERS
      aggregation:
      - - sum
        - - field
          - 15
          - null
      breakout:
      - - field
        - 12
        - temporal-unit: month
...

Expected behavior
This is 1.38.4:

...
dataset_query:
  type: query
  query:
    source-query:
      source-table: /databases/Sample Dataset/schemas/PUBLIC/tables/ORDERS
      aggregation:
      - - sum
        - - field-id
          - /databases/Sample Dataset/schemas/PUBLIC/tables/ORDERS/fields/TOTAL
      breakout:
      - - datetime-field
        - - field-id
          - /databases/Sample Dataset/schemas/PUBLIC/tables/ORDERS/fields/CREATED_AT
        - month
...

Information about your Metabase Installation:
1.39.0.1
@flamber flamber added Type:Bug Product defects Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Operation/Serialization Enterprise contents migration labels Apr 26, 2021
@jeff303 jeff303 self-assigned this Apr 26, 2021
@rlotun rlotun mentioned this issue Apr 28, 2021
Closed
5 tasks
@jeff303 jeff303 linked a pull request May 3, 2021 that will close this issue
Serialization fixes for x.39 #15858
Merged
17 tasks
@jeff303 jeff303 mentioned this issue May 3, 2021
Merged
17 tasks
@jeff303
Copy link
Contributor

jeff303 commented May 7, 2021

This should be fixed by commit 1 on #15858.

@flamber flamber mentioned this issue May 7, 2021
Closed
@rlotun rlotun added this to the 0.39.3 milestone May 17, 2021
@flamber
Copy link
Contributor Author

flamber commented May 27, 2021

Fixed by #15858 - will be part of 1.39.3

@flamber flamber closed this as completed May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeff303 jeff303

Labels
Operation/Serialization Enterprise contents migration Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Projects
None yet
Milestone
0.39.3
Development

Successfully merging a pull request may close this issue.

Serialization fixes for x.39 metabase/metabase
3 participants
@rlotun @flamber @jeff303