Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization: field-literal converted to field since 1.39.0 #15971

Closed
flamber opened this issue May 7, 2021 · 4 comments · Fixed by #15858
Closed

Serialization: field-literal converted to field since 1.39.0 #15971

flamber opened this issue May 7, 2021 · 4 comments · Fixed by #15858
Assignees
Labels
Operation/Serialization Enterprise contents migration Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Milestone

Comments

@flamber
Copy link
Contributor

flamber commented May 7, 2021

Describe the bug
Regression since 1.39.0, which kinda reopens #15048, but keeping as new issue, since it seems to be different and "only" breaking all field-literal dimensions, which are converted to field.

EDIT: Could it simply be caused by Serialization correctly dumping as field, but the load process reads sum as a file reference, which then results in a null value on the target instance?

To Reproduce
See #15048 for steps.

On 1.39.0 it creates the following dump - only showing a snippet, since #15812 caused a lot of other problems

...
    filter:
    - '>'
    - - field
      - sum
      - base-type: type/Float
    - 100
...

On 1.38.4 it does a correct dump:

...
    filter:
    - '>'
    - - field-literal
      - sum
      - type/Float
    - 100
...
@flamber flamber added Type:Bug Product defects Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Operation/Serialization Enterprise contents migration labels May 7, 2021
@jeff303 jeff303 self-assigned this May 7, 2021
@jeff303
Copy link
Contributor

jeff303 commented May 11, 2021

Commit 8 under #15858 should fix this one.

@camsaul
Copy link
Member

camsaul commented May 12, 2021

Dumping as field is by design. field-literal isn't used anymore. Everything is a field. So it seems like it is an issue with load

@jeff303
Copy link
Contributor

jeff303 commented May 12, 2021

Dumping as field is by design. field-literal isn't used anymore. Everything is a field. So it seems like it is an issue with load

Yes, this is fixed by this commit. The "real problem" in this case was that the string was always being interpreted by load as a fully qualified name, when in fact, it can sometimes just be a string (ex: like in this case).

@rlotun rlotun linked a pull request May 13, 2021 that will close this issue
17 tasks
@rlotun rlotun added this to the 0.39.3 milestone May 17, 2021
@flamber
Copy link
Contributor Author

flamber commented May 27, 2021

Fixed by #15858 - will be part of 1.39.3

@flamber flamber closed this as completed May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Operation/Serialization Enterprise contents migration Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants