-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LDAP settings form hitting wrong API endpoint on save #16173
Labels
Type:Tech Debt
or Refactoring
Milestone
Comments
This also seems to be true for the email settings component, which also uses |
flamber
added
Type:Tech Debt
or Refactoring
and removed
.Needs Triage
Type:Bug
Product defects
labels
May 21, 2021
This was referenced May 21, 2021
nemanjaglumac
added a commit
that referenced
this issue
May 25, 2021
This was referenced Jan 9, 2023
This was referenced Jan 24, 2023
Merged
This was referenced Jan 31, 2023
Closed
This was referenced Mar 21, 2024
Merged
This was referenced Mar 29, 2024
Merged
Merged
This was referenced Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It appears that the LDAP settings page is hitting
/api/settings
rather than/api/ldap/settings
. The latter endpoint validates that a connection to the LDAP server can be established and returns an error if not. This is pretty important to fix since without this validation, it's easy to save invalid LDAP credentials and then only discover the error later.We're already trying to map the
updateSettings
prop toupdateLdapSettings
inSettingsLdapForm.jsx
but this is broken, maybe due to something inSettingsBatchForm
?metabase/frontend/src/metabase/admin/settings/components/SettingsLdapForm.jsx
Lines 10 to 13 in f93680a
I'm comparing this to
SettingsSlackForm.jsx
which does something similar, but doesn't useSettingsBatchForm
, and it works properly. I don't really know enough about react/redux to diagnose this further.To Reproduce
Steps to reproduce the behavior:
/api/settings
is hit rather than/api/ldap/settings
Expected behavior
We should be hitting
/api/ldap/settings
and displaying an error if one is returned from the backendThe text was updated successfully, but these errors were encountered: