Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive page shows error for users with collection curate permissions and no data permissions #16617

Closed
kulyk opened this issue Jun 16, 2021 · 1 comment · Fixed by #17004
Closed
Assignees
Labels
Administration/Permissions Collection or Data permissions Organization/Collections Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone

Comments

@kulyk
Copy link
Member

kulyk commented Jun 16, 2021

Users with collection curate permissions and no data permissions see an error when visiting the archive page. Note that they can archive and unarchive items (unarchiving is currently broken, see issue #15253 and PR #16590)

To Reproduce

  1. Log in as a non-admin user with collection curate access and no data permissions
  2. Go to /collection/archive/
  3. See an error message like Input to add-table-db-id-clause does not match schema: �[0;33m [(named (named (not (instance? clojure.lang.IPersistentMap nil)) "Valid map") query) nil]

Expected behavior
A user should see a list of archived items

Screenshots

Screenshot 2021-06-16 at 11 52 46

Information about your Metabase Installation:

Metabase version: latest master (commit)
Metabase hosting environment: local, master branch
Metabase internal database: H2 (default), sample dataset
Add any other context about the problem here.

@kulyk kulyk added Type:Bug Product defects Administration/Permissions Collection or Data permissions Organization/Collections .Needs Triage .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. labels Jun 16, 2021
kulyk added a commit that referenced this issue Jun 16, 2021
@flamber flamber added Priority:P2 Average run of the mill bug and removed .Needs Triage labels Jun 16, 2021
kulyk added a commit that referenced this issue Jun 16, 2021
@kulyk kulyk added the .Reproduced Issues reproduced in test (usually Cypress) label Jun 16, 2021
@dpsutton
Copy link
Contributor

I was trying to reproduce this.

I have a group called noaccess.

image

With user test@test.com in it
image

That group has curate access to collections
image

But i cannot trigger the bug:
image

When that group has no access to collections I also still cannot reproduce
image

I also used a prebuilt db that had some users without data access.
logging in with user nodata@metabase.test and password 12341234
image

This was referenced Feb 5, 2024
@replay-io replay-io bot mentioned this issue Apr 24, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administration/Permissions Collection or Data permissions Organization/Collections Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants