-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching between date filter widget type in field filters show NaN dates #16756
Labels
.Frontend
Priority:P3
Cosmetic bugs, minor bugs with a clear workaround
Querying/Parameters & Variables
Filter widgets, field filters, variables etc.
.Reproduced
Issues reproduced in test (usually Cypress)
Type:Bug
Product defects
Milestone
Comments
paoliniluis
added
Type:Bug
Product defects
.Needs Triage
.Frontend
Priority:P3
Cosmetic bugs, minor bugs with a clear workaround
and removed
.Needs Triage
Type:Bug
Product defects
labels
Jun 24, 2021
flamber
added
the
Querying/Parameters & Variables
Filter widgets, field filters, variables etc.
label
Jul 23, 2021
This was referenced Oct 1, 2021
nemanjaglumac
added a commit
that referenced
this issue
Mar 31, 2022
nemanjaglumac
added a commit
that referenced
this issue
Apr 1, 2022
nemanjaglumac
added a commit
that referenced
this issue
Apr 2, 2022
* Extract repro for #16756 * Optimize looping through sql date field fitlers * Optimize looping through sql number field fitlers * Optimize looping through sql string field fitlers * Extract common helper * Run only native filters in the current branch * Reduce flakiness in `type` * Merge field filters together * Run tests on `master` again
This was referenced Nov 1, 2023
Closed
This was referenced Feb 5, 2024
Merged
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
.Frontend
Priority:P3
Cosmetic bugs, minor bugs with a clear workaround
Querying/Parameters & Variables
Filter widgets, field filters, variables etc.
.Reproduced
Issues reproduced in test (usually Cypress)
Type:Bug
Product defects
Describe the bug
When switching the filter widget type in date field filters makes the filter to show invalid dates. For example: switching between a date range filter and single date.
Logs
Seems like a frontend issue only:
To Reproduce
Expected behavior
Filter to be cleared so user can input a date and does not see an error
Screenshots
Information about your Metabase Installation:
Severity
Not severe, a FE glitch that can be bypassed by clicking on the cross and cleaning the filter
Additional context
None
The text was updated successfully, but these errors were encountered: