-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clicking on cancel edit dashboard without any changes removes the dashboard filter #17139
Closed
Tracked by
#21485
Labels
Priority:P3
Cosmetic bugs, minor bugs with a clear workaround
Querying/Parameters & Variables
Filter widgets, field filters, variables etc.
Reporting/Dashboards
.Reproduced
Issues reproduced in test (usually Cypress)
Type:Bug
Product defects
Comments
paoliniluis
added
Priority:P3
Cosmetic bugs, minor bugs with a clear workaround
Querying/Parameters & Variables
Filter widgets, field filters, variables etc.
and removed
.Needs Triage
labels
Jul 20, 2021
This also resets multiple filters at once. |
nemanjaglumac
added a commit
that referenced
this issue
Jul 21, 2021
…emoves the dashboard filter (#17140)
Duplicate of #5332 |
nemanjaglumac
added a commit
that referenced
this issue
Aug 6, 2021
…emoves the dashboard filter (#17140)
nemanjaglumac
added a commit
that referenced
this issue
Apr 28, 2022
nemanjaglumac
added a commit
that referenced
this issue
Apr 28, 2022
nemanjaglumac
added a commit
that referenced
this issue
Apr 29, 2022
This was referenced Nov 21, 2022
1 task
1 task
1 task
This was referenced Feb 5, 2024
Merged
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority:P3
Cosmetic bugs, minor bugs with a clear workaround
Querying/Parameters & Variables
Filter widgets, field filters, variables etc.
Reporting/Dashboards
.Reproduced
Issues reproduced in test (usually Cypress)
Type:Bug
Product defects
Describe the bug
On a dashboard that already has some filter set, entering edit mode and then either hitting the "Cancel" button or the "Save" button without making any change will reset whatever filter was already set before.
Logs
To Reproduce
Steps to reproduce the behavior:
Expected behavior
If there were not any changes made, previously defined filter should be intact.
Screenshots
Information about your Metabase Installation:
local dev,
master
, x.40.1-SNAPSHOT, 28aab0fSeverity
Seems pretty unpredictable. I'd say P2.
Additional context
Tested as back as x.38.4 and it was broken all along.
The text was updated successfully, but these errors were encountered: