Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on cancel edit dashboard without any changes removes the dashboard filter #17139

Closed
Tracked by #21485
nemanjaglumac opened this issue Jul 20, 2021 · 2 comments
Closed
Tracked by #21485
Assignees
Labels
Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Parameters & Variables Filter widgets, field filters, variables etc. Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects

Comments

@nemanjaglumac
Copy link
Member

Describe the bug
On a dashboard that already has some filter set, entering edit mode and then either hitting the "Cancel" button or the "Save" button without making any change will reset whatever filter was already set before.

Logs

To Reproduce
Steps to reproduce the behavior:

  1. Go to any dashboard that already has the dashboard filter connected to any of the fields
  2. Set the filter value if it already wasn't set
  3. Note that the url changes and it now includes the filter and its value (correct behavior)
  4. Click on the pencil icon to enter Dashboard edit mode
  5. Click on "Cancel" button (clicking the "Save" button produces the same behavior but it shouldn't even be possible to click it if there were no changes)
  6. The filter is now empty and the url loses all info about the filter.

Expected behavior
If there were not any changes made, previously defined filter should be intact.

Screenshots

Information about your Metabase Installation:
local dev, master, x.40.1-SNAPSHOT, 28aab0f

Severity
Seems pretty unpredictable. I'd say P2.

Additional context
Tested as back as x.38.4 and it was broken all along.

@paoliniluis paoliniluis added Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Parameters & Variables Filter widgets, field filters, variables etc. and removed .Needs Triage labels Jul 20, 2021
@nemanjaglumac
Copy link
Member Author

This also resets multiple filters at once.

@flamber
Copy link
Contributor

flamber commented Jul 22, 2021

Duplicate of #5332

@flamber flamber marked this as a duplicate of #5332 Jul 22, 2021
@flamber flamber closed this as completed Jul 22, 2021
nemanjaglumac added a commit that referenced this issue Aug 6, 2021
nemanjaglumac added a commit that referenced this issue Aug 6, 2021
nemanjaglumac added a commit that referenced this issue Apr 28, 2022
nemanjaglumac added a commit that referenced this issue Apr 28, 2022
github-actions bot pushed a commit that referenced this issue Apr 28, 2022
nemanjaglumac added a commit that referenced this issue Apr 29, 2022
Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Parameters & Variables Filter widgets, field filters, variables etc. Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Development

No branches or pull requests

4 participants