-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XLSX export of "X of Y" (eg. Month of Year) is formatted as date column #18729
Comments
@flamber this is what SheetJS sees for {
"A1": {
"t": "s",
"v": "Created At",
"h": "Created At",
"w": "Created At"
},
"B1": {
"t": "s",
"v": "Product → Category",
"h": "Product → Category",
"w": "Product → Category"
},
"C1": {
"t": "s",
"v": "Count",
"h": "Count",
"w": "Count"
},
"A2": {
"t": "n",
"v": 1,
"w": "January 1, 1900, 12:00 AM"
},
"B2": {
"t": "s",
"v": "Doohickey",
"h": "Doohickey",
"w": "Doohickey"
},
"C2": {
"t": "n",
"v": 408,
"w": "408"
},
"A3": {
"t": "n",
"v": 1,
"w": "January 1, 1900, 12:00 AM"
},
"B3": {
"t": "s",
"v": "Gadget",
"h": "Gadget",
"w": "Gadget"
},
"C3": {
"t": "n",
"v": 452,
"w": "452"
},
} |
Also, please let me know if you'd like this covered for |
@nemanjaglumac I'm not sure if we're able to do similar translation as in-app, but otherwise it should return numeric value similar to CSV. And given the regression, then we should also cover CSV, so we don't regress there too. |
…d as date column (#18792)
Unassigning myself; when I started to dig into this it seemed pretty tricky to get exactly right. More of a mini project than a quick fix IMO |
Describe the bug
XLSX export of "X of Y" (eg. Month of Year) is formatted as date column.
Workaround: In they XLSX viewer (Excel, Numbers, Calc), disable date formatting on the column.
To Reproduce
Expected behavior
Preferably return the value similar to what is shown in Metabase (this might be tricky, especially with i18n), otherwise return the numeric value without date formatting.
Information about your Metabase Installation:
Tested 0.40.5 thru 0.41.1 - regression since 0.41.0
Additional context
Lightly related to #18572 and #18219
The text was updated successfully, but these errors were encountered: