Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a grouping leaves grouping columns partially visible #18817

Closed
paoliniluis opened this issue Nov 2, 2021 · 4 comments
Closed

Removing a grouping leaves grouping columns partially visible #18817

paoliniluis opened this issue Nov 2, 2021 · 4 comments
Assignees
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/GUI Query builder catch-all, including simple mode Type:Bug Product defects Visualization/Tables/old-pivoted .Wanted: MLv2 Issues that will be fixed (or easier to fix, or possible to fix) when we have MLv2
Milestone

Comments

@paoliniluis
Copy link
Contributor

paoliniluis commented Nov 2, 2021

Describe the bug
When starting with a saved question, adding 2 groupings and then deleting one, leaves some orphan column names in the top bar, that are even functional

Logs
NA

To Reproduce

  1. With the sample dataset create a new GUI question (Let's say, just click the people table and save it as People).
  2. access the saved question (or refresh the page), and then add 2 group by's (name and source). Then remove one of those
  3. see the column titles still populated with some groupings still visible

Expected behavior
Just see the columns that are in the groupings

Screenshots
Stats
image

On a 40.5 I was testing with:
image

Information about your Metabase Installation:

  • Your browser and the version: Brave latest and Firefox 93
  • Your operating system: Ubuntu 21.10
  • Your databases: H2
  • Metabase version: master branch and 40.5
  • Metabase hosting environment: Docker
  • Metabase internal database: H2

Severity
Cosmetic

Additional context
Might be a cousin of #13772, but I'm not very sure

@paoliniluis paoliniluis added Type:Bug Product defects Type:UX Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Frontend Querying/GUI Query builder catch-all, including simple mode labels Nov 2, 2021
@flamber flamber added Visualization/Tables Raw, summarized, and pivoted tables and removed Type:UX labels Nov 3, 2021
@flamber
Copy link
Contributor

flamber commented Nov 3, 2021

This only occurs on pivoted table (old pivot table). Related #12368

  1. Simple question > Sample Dataset > Products - save as "Q1"
  2. Refresh browser
  3. Notebook - summarize Count by Category and Vendor
  4. It should automatically change to pivoted table
  5. Click the data toggle in the bottom - it will show the pivoted table underneath.

@flamber flamber added Visualization/Tables/old-pivoted and removed Visualization/Tables Raw, summarized, and pivoted tables labels Nov 10, 2021
@ranquild ranquild added .Wanted: MLv2 Issues that will be fixed (or easier to fix, or possible to fix) when we have MLv2 .Backend and removed .Frontend .FixMBQLScope42 labels Oct 31, 2023
@kamilmielnik kamilmielnik self-assigned this Nov 8, 2023
@kamilmielnik
Copy link
Contributor

Reproducible in 0.40.5.
Fixed in master (d35c779).
Marking as fixed in the next version (48).
Closing.

@kamilmielnik kamilmielnik removed their assignment Nov 8, 2023
@uladzimirdev uladzimirdev self-assigned this Nov 13, 2023
@metamben metamben assigned metamben and unassigned uladzimirdev Nov 13, 2023
@metamben metamben reopened this Nov 13, 2023
metamben added a commit that referenced this issue Nov 13, 2023
Fixes #18817.

It verifies both that after removing breakouts the returned columns
are valid, as well as that given a question based on an aggregated
source query, a fields corresponding a breakout can be removed.
This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/GUI Query builder catch-all, including simple mode Type:Bug Product defects Visualization/Tables/old-pivoted .Wanted: MLv2 Issues that will be fixed (or easier to fix, or possible to fix) when we have MLv2
Projects
None yet
Development

No branches or pull requests

6 participants