-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Build Card Save modal does not properly show errors from API #21597
Labels
.Frontend
Priority:P3
Cosmetic bugs, minor bugs with a clear workaround
Querying/Native
The SQL/native query editor
Querying/Parameters & Variables
Filter widgets, field filters, variables etc.
.Reproduced
Issues reproduced in test (usually Cypress)
Type:Bug
Product defects
Milestone
Comments
camsaul
added
Type:Bug
Product defects
.Needs Triage
.Frontend
Querying/GUI
Query builder catch-all, including simple mode
labels
Apr 11, 2022
flamber
added
Priority:P3
Cosmetic bugs, minor bugs with a clear workaround
Querying/Parameters & Variables
Filter widgets, field filters, variables etc.
Querying/Native
The SQL/native query editor
and removed
.Needs Triage
Querying/GUI
Query builder catch-all, including simple mode
labels
Apr 12, 2022
Reproduce with PR #21598:
Screencast-2022-04-13_11.06.53.mp4 |
nemanjaglumac
added a commit
that referenced
this issue
Sep 1, 2022
* Fix native query * Replace deprecated `cy.server` and `cy.route` * Add database through API rather than using UI * Remove superfluous `visit` `openNativeEditor` already contains `cy.visit("/")` * Use Postgres instead of H2 for a second database * Speed typing up a bit * Do not use hard coded IDs * Update test title * Move spec to `native` reproductions
nemanjaglumac
added a commit
that referenced
this issue
Sep 1, 2022
* Fix native query * Replace deprecated `cy.server` and `cy.route` * Add database through API rather than using UI * Remove superfluous `visit` `openNativeEditor` already contains `cy.visit("/")` * Use Postgres instead of H2 for a second database * Speed typing up a bit * Do not use hard coded IDs * Update test title * Move spec to `native` reproductions
nemanjaglumac
added a commit
that referenced
this issue
Sep 2, 2022
* Fix native query * Replace deprecated `cy.server` and `cy.route` * Add database through API rather than using UI * Remove superfluous `visit` `openNativeEditor` already contains `cy.visit("/")` * Use Postgres instead of H2 for a second database * Speed typing up a bit * Do not use hard coded IDs * Update test title * Move spec to `native` reproductions
snoe
pushed a commit
that referenced
this issue
Sep 6, 2022
* Fix native query * Replace deprecated `cy.server` and `cy.route` * Add database through API rather than using UI * Remove superfluous `visit` `openNativeEditor` already contains `cy.visit("/")` * Use Postgres instead of H2 for a second database * Speed typing up a bit * Do not use hard coded IDs * Update test title * Move spec to `native` reproductions
This was referenced Mar 15, 2023
1 task
8 tasks
This was referenced Aug 10, 2023
This was referenced Feb 5, 2024
Merged
Open
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
.Frontend
Priority:P3
Cosmetic bugs, minor bugs with a clear workaround
Querying/Native
The SQL/native query editor
Querying/Parameters & Variables
Filter widgets, field filters, variables etc.
.Reproduced
Issues reproduced in test (usually Cypress)
Type:Bug
Product defects
I ran into this while fixing #14145.
After PR #21598, the API returns a 400 error response (actually 202 with
_status
since the endpoint is async, but still effectively a 400):But the Save Card modal just shows a Type Error:
Console logs:
It should show the actual error message here.
Note that #14145 is a custom success escalation so this should probably be considered one as well
The text was updated successfully, but these errors were encountered: