Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreign Key Relationships in Object Detail View incorrectly default to first foreign key #21757

Closed
iethree opened this issue Apr 19, 2022 · 1 comment · Fixed by #22013
Closed
Assignees
Labels
.Correctness .Frontend Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/Tables Raw, summarized, and pivoted tables
Milestone

Comments

@iethree
Copy link
Contributor

iethree commented Apr 19, 2022

Describe the bug
Often (but not always, I haven't been able to figure out the cause here), clicking the foreign-key relationship links in an object detail component links to the first foreign key for the foreign table, instead of the desired foreign key.

To Reproduce
In the sample db:

  1. Brows the products table
  2. Click on id 6 to view details for that product
  3. See that it's linked to 93 orders
  4. Click on the 93 orders linked
  5. See that you're taken to a detail item linked to product id 1 instead of 6.

Expected behavior
We should get a new question filtered by the correct foreign key instead of the first foreign key and/or taken to a detail record with the correct foreign key.

Screenshots

wrongIdlink.mp4
wrongItemId.mp4

Information about your Metabase Installation:

Your browser and the version: Google Chrome Version 100.0.4896.127 (Official Build) (64-bit)
Your operating system: Ubutntu 20.04
Your databases: Postgres 14.2
Metabase version: master branch - 2022-04-19 - v0.42.1-SNAPSHOT"
Metabase hosting environment: local development
Metabase internal database: H2

Severity

Makes the relationships links useless in many situations

@iethree iethree added Type:Bug Product defects .Needs Triage labels Apr 19, 2022
@flamber flamber added Priority:P2 Average run of the mill bug .Correctness .Frontend Visualization/Tables Raw, summarized, and pivoted tables .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. and removed .Needs Triage labels Apr 22, 2022
@flamber
Copy link
Contributor

flamber commented Apr 22, 2022

This is kinda a repeat of #13717
Regression since 0.43.0-rc1

@flamber flamber added this to the 0.43 milestone Apr 22, 2022
@kulyk kulyk self-assigned this Apr 22, 2022
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Apr 26, 2022
This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Correctness .Frontend Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/Tables Raw, summarized, and pivoted tables
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants