Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show Object Detail when there is 1 row - otherwise always show Table #13717

Closed
flamber opened this issue Nov 6, 2020 · 0 comments · Fixed by #18016
Closed

Only show Object Detail when there is 1 row - otherwise always show Table #13717

flamber opened this issue Nov 6, 2020 · 0 comments · Fixed by #18016
Assignees
Labels
.Correctness Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/
Milestone

Comments

@flamber
Copy link
Contributor

flamber commented Nov 6, 2020

Describe the bug
When filtering on a field type "Entity Key", but the result might contain more than 1 row (eg. because of composite keys #3475), then an Object View is shown, which leads to incorrect representation of the results.

To Reproduce

  1. Admin > Data Model > Sample Dataset > Orders
  2. Change "ID" field type to "No special type", and "Quantity" to "Entity Key"
  3. Simple question > Sample Dataset > Orders - click any row of Quantity, which then shows Object Detail visualization even though the request result returns more than 1 row (2000 in this case).
    image

Expected behavior
Only show Object Detail, when the result is 1 row - otherwise always show a table.
This will protect against accidental incorrect Field Type, or when the data somehow deviates from expectations.

Information about your Metabase Installation:
Metabase 0.34.3 thru 0.37.0.2 - probably always been the behavior.

Additional context
Related to #7599 and #9447 and #11503

@flamber flamber added Type:Bug Product defects Priority:P2 Average run of the mill bug Visualization/ .Correctness Querying/GUI Query builder catch-all, including simple mode labels Nov 6, 2020
@nemanjaglumac nemanjaglumac added this to Backlog in Cypress Testing Nov 12, 2020
nemanjaglumac added a commit that referenced this issue Nov 12, 2020
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Nov 13, 2020
@rlotun rlotun added this to x.37.3+ Bug Fixes (x.37.3: Nov 30) in 38 Product Pod Planning Nov 23, 2020
@alxnddr alxnddr self-assigned this Sep 22, 2021
38 Product Pod Planning automation moved this from 38.1+ Bug Fixes to Closed Issues and PRs Sep 23, 2021
@flamber flamber added this to the 0.41 milestone Sep 23, 2021
@deploysentinel deploysentinel bot mentioned this issue Jul 7, 2023
1 task
@deploysentinel deploysentinel bot mentioned this issue Aug 17, 2023
1 task
This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Correctness Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/
Projects
38 Product Pod Planning
  
Closed Issues and PRs
Development

Successfully merging a pull request may close this issue.

3 participants