Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewing tables in Data Model is registered in "Recently viewed" #21984

Closed
flamber opened this issue Apr 24, 2022 · 0 comments · Fixed by #23780
Closed

Viewing tables in Data Model is registered in "Recently viewed" #21984

flamber opened this issue Apr 24, 2022 · 0 comments · Fixed by #23780
Assignees
@calherries
Labels
Administration/Table Metadata .Backend Organization/Search Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.44

Comments

@flamber
Copy link
Contributor

flamber commented Apr 24, 2022

Describe the bug
When viewing tables in Admin > Data Model, then it's registered as "Recently viewed" in the global search and "Pick up where you left off" on the homepage.

To Reproduce

  1. Click global search, which should show the past items viewed
    image
  2. Go to Admin > Data Model > Sample > Reviews
    image
  3. Exit admin, click global search
    image

Expected behavior
Viewing items in Data Model should not be registered in the view log, since it's not viewing any data.

Information about your Metabase Installation:
Tested 0.41.6 thru 0.43.0-rc1

Additional context
Related to #18439
@flamber flamber added Type:Bug Product defects Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Administration/Table Metadata Organization/Search .Backend labels Apr 24, 2022
@nemanjaglumac nemanjaglumac added this to Backlog in Cypress Testing via automation Apr 25, 2022
@nemanjaglumac nemanjaglumac moved this from Backlog to To Do in Cypress Testing Jun 29, 2022
nemanjaglumac added a commit that referenced this issue Jun 29, 2022
@nemanjaglumac
Add repro for #21984
fd79cea
@nemanjaglumac nemanjaglumac mentioned this issue Jun 29, 2022
Merged
nemanjaglumac added a commit that referenced this issue Jun 30, 2022
@nemanjaglumac
Repro #21984: Viewing tables in Data Model is registered in "Recently…
bc522f4 
… viewed" (#23610)
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Jun 30, 2022
github-actions bot pushed a commit that referenced this issue Jun 30, 2022
@nemanjaglumac
Repro #21984: Viewing tables in Data Model is registered in "Recently…
d1c6746 
… viewed" (#23610)
nemanjaglumac added a commit that referenced this issue Jun 30, 2022
@github-actions @nemanjaglumac
Repro #21984: Viewing tables in Data Model is registered in "Recently…
f621c98 
… viewed" (#23610) (#23628)

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
@nemanjaglumac nemanjaglumac removed this from To Do in Cypress Testing Jun 30, 2022
@calherries calherries mentioned this issue Jul 8, 2022
Merged
calherries added a commit that referenced this issue Jul 12, 2022
@calherries @nemanjaglumac
Fix for #21984: Viewing tables in Data Model is registered in "Recent…
2c1404f 
…ly viewed" (#23780)

* Add explicit ignore_true parameter to Tables.load requests in admin panel to avoid counting the requests as a table view

* Remove .skip for repro

* Fix formatting

* Adapt repro to the fix

Repro was written before I know what the fix would look like.

We're conditionally choosing whether to display `HomePopularSection` or `HomeRecentSection`.
With this fix applied, data model table visit is not registered any more so there is nothing else really
that the test user visited. Hence, "Pick where you left off" is never displayed on the page and we
display `HomePopularSection` instead.

This adaption reflects those changes.

* Revert "Add explicit ignore_true parameter to Tables.load requests in admin panel to avoid counting the requests as a table view"

This reverts commit f887d0d.

* Remove :table-read event from GET api/table/:id endpoint

* Remove unused ns

Co-authored-by: Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
github-actions bot pushed a commit that referenced this issue Jul 21, 2022
@calherries @nemanjaglumac
Fix for #21984: Viewing tables in Data Model is registered in "Recent…
70c2073 
…ly viewed" (#23780)

* Add explicit ignore_true parameter to Tables.load requests in admin panel to avoid counting the requests as a table view

* Remove .skip for repro

* Fix formatting

* Adapt repro to the fix

Repro was written before I know what the fix would look like.

We're conditionally choosing whether to display `HomePopularSection` or `HomeRecentSection`.
With this fix applied, data model table visit is not registered any more so there is nothing else really
that the test user visited. Hence, "Pick where you left off" is never displayed on the page and we
display `HomePopularSection` instead.

This adaption reflects those changes.

* Revert "Add explicit ignore_true parameter to Tables.load requests in admin panel to avoid counting the requests as a table view"

This reverts commit f887d0d.

* Remove :table-read event from GET api/table/:id endpoint

* Remove unused ns

Co-authored-by: Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
@flamber flamber added this to the 0.44 milestone Jul 21, 2022
diogormendes pushed a commit that referenced this issue Aug 1, 2022
@github-actions @calherries @nemanjaglumac
Fix for #21984: Viewing tables in Data Model is registered in "Recent…
e85e261 
…ly viewed" (#23780) (#24188)

* Add explicit ignore_true parameter to Tables.load requests in admin panel to avoid counting the requests as a table view

* Remove .skip for repro

* Fix formatting

* Adapt repro to the fix

Repro was written before I know what the fix would look like.

We're conditionally choosing whether to display `HomePopularSection` or `HomeRecentSection`.
With this fix applied, data model table visit is not registered any more so there is nothing else really
that the test user visited. Hence, "Pick where you left off" is never displayed on the page and we
display `HomePopularSection` instead.

This adaption reflects those changes.

* Revert "Add explicit ignore_true parameter to Tables.load requests in admin panel to avoid counting the requests as a table view"

This reverts commit f887d0d.

* Remove :table-read event from GET api/table/:id endpoint

* Remove unused ns

Co-authored-by: Nemanja <31325167+nemanjaglumac@users.noreply.github.com>

Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>
Co-authored-by: Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
@deploysentinel deploysentinel bot mentioned this issue Dec 13, 2022
Closed
@deploysentinel deploysentinel bot mentioned this issue Dec 23, 2022
Merged
This was referenced Jan 9, 2023
Merged
Merged
@deploysentinel deploysentinel bot mentioned this issue Jan 17, 2023
Merged
This was referenced Jan 24, 2023
Merged
Merged
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calherries calherries

Labels
Administration/Table Metadata .Backend Organization/Search Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.44
Development

Successfully merging a pull request may close this issue.

Fix for #21984: Viewing tables in Data Model is registered in "Recently viewed" metabase/metabase
3 participants
@flamber @nemanjaglumac @calherries