-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selecting language Indonesian causes error #22192
Comments
Refreshing the page won't help, the user is completely locked out. |
I've got a small change locally that will default the language to English (assuming this acceptable behavior) , and I'm working on putting an E2E test together now |
We’ve tracked things down to this:
But in java 11:
Because of this difference, everything works fine in Java 17 land -> the |
Edit: this was meant to be put in my PR... sorry |
Setting a users language to Indonesian throws an error that the user cannot recover from
Logs
Can be seen in the gif below, but it appears that Moment is attempting to load the locale
in
. The locale for Indonesian that we use isid
.To Reproduce
Steps to reproduce the behavior:
On a Fresh install of metabase
Expected behavior
Page to be refreshed and displayed in Indonesian
Screenshots
Information about your Metabase Installation:
Severity
Seems to put us in an irrecoverable state. Potential P1
Additional context
@flamber @diegmonti
We have confirmed that we call
PUT /api/user/:id
with the correct locale, but it appears to be set incorrectly inwindow.MetabaseLocalization
. The terminal console will displayLocale 'in' not found
, which suggests that maybe something is happening hereThe text was updated successfully, but these errors were encountered: