Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Model > Visibility buttons should "signal" they are clickable #22266

Closed
nemanjaglumac opened this issue Apr 29, 2022 · 0 comments · Fixed by #22268
Closed

Data Model > Visibility buttons should "signal" they are clickable #22266

nemanjaglumac opened this issue Apr 29, 2022 · 0 comments · Fixed by #22268
Assignees
Labels
.CSS Difficulty:Easy Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Milestone

Comments

@nemanjaglumac
Copy link
Member

Describe the bug
Visibility buttons in data model settings do not have a pointer cursor when you hover over them so it's not immediately clear that you can click on them. They do change colors, though.

Logs
N/A

To Reproduce
Steps to reproduce the behavior:

  1. Sign in as admin
  2. Go to admin > data model
  3. Choose any of the tables in Sample Database
  4. Under the name and the description of the table, there should be VISIBILITY and then some buttons right to it (those buttons should signal they are clickable but they don't)
  5. Hover over "Queryable" or "Hidden" and notice the cursor is changing to the "text", which is first and foremost wrong in itself. But really, it should change to the "pointer".

Expected behavior
Cursor should change to the pointer when hovering visibility buttons.

Information about your Metabase Installation:
local dev, master, dfcc2a1, H2, Sample Database

Severity
P3 because settings still work, but I was confused when I realized I could click on some strings and thought that was a bug, until realizing that it was the actual button.

Additional context
Regression most likely from the v43.
Tested on 42.4 and it was working as expected back then.

@nemanjaglumac nemanjaglumac added Type:Bug Product defects .CSS Difficulty:Easy .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. labels Apr 29, 2022
@nemanjaglumac nemanjaglumac self-assigned this Apr 29, 2022
@nemanjaglumac nemanjaglumac added the Priority:P3 Cosmetic bugs, minor bugs with a clear workaround label Apr 29, 2022
@nemanjaglumac nemanjaglumac added this to the 0.43 milestone Apr 29, 2022
nemanjaglumac added a commit that referenced this issue Apr 29, 2022
Fixes #22266.

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.CSS Difficulty:Easy Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant