Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exports of questions with non-ASCII names shows encoded filenames #22639

Closed
flamber opened this issue May 11, 2022 · 1 comment · Fixed by #22734
Closed

Exports of questions with non-ASCII names shows encoded filenames #22639

flamber opened this issue May 11, 2022 · 1 comment · Fixed by #22734
Assignees
@gusaiani
Labels
Customization/i18n .Frontend Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Export Type:Bug Product defects
Milestone
0.43.1

Comments

@flamber
Copy link
Contributor

flamber commented May 11, 2022

Describe the bug
Exports of questions with non-ASCII names shows encoded filenames

Regression in 0.43.0

To Reproduce

  1. Native > Sample > select 1 - save question as Danish:Æbleflæsk - Greek:παράδειγμα
  2. Export as CSV
  3. The file is called danish_%C3%A6blefl%C3%A6sk___greek_%CF%80%CE%B1%CF%81%CE%B1%CE%B4%CE%B5%CE%B9%CE%B3%CE%BC%CE%B1_2022-05-11T19 44 52.160523+02 00.csv

Expected behavior
0.42.4 would return: danish_æbleflæsk___greek_παραδειγμα_2022-05-11T19 47 54.244488+02 00.csv

Information about your Metabase Installation:
Tested 0.42.4 thru 0.43.0 - regression in 0.43.0
@flamber flamber added Type:Bug Product defects Priority:P2 Average run of the mill bug Customization/i18n Reporting/Export .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. labels May 11, 2022
@noahmoss noahmoss self-assigned this May 12, 2022
@noahmoss
Copy link
Member

Introduced by #21037

@noahmoss noahmoss removed their assignment May 12, 2022
@gusaiani gusaiani self-assigned this May 16, 2022
@gusaiani gusaiani mentioned this issue May 16, 2022
Merged
@flamber flamber added this to the 0.43.1 milestone May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gusaiani gusaiani

Labels
Customization/i18n .Frontend Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Export Type:Bug Product defects
Projects
None yet
Milestone
0.43.1
Development

Successfully merging a pull request may close this issue.

URIDecode exported question filenames metabase/metabase
3 participants
@gusaiani @flamber @noahmoss