Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewing Metadata for a Model and cancelling can result in error, and further in blank screen #23022

Closed
flamber opened this issue May 28, 2022 · 3 comments
Closed

Viewing Metadata for a Model and cancelling can result in error, and further in blank screen #23022

flamber opened this issue May 28, 2022 · 3 comments
Assignees
@daltojohnso
Labels
.Frontend Priority:P2 Average run of the mill bug Querying/Models aka Datasets Querying/Native The SQL/native query editor .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Milestone
0.43.3

Comments

@flamber
Copy link
Contributor

flamber commented May 28, 2022

Describe the bug
Viewing Metadata for a Model and cancelling can result in error, and further in blank screen.

To Reproduce

  1. Native > Sample > select * from products limit 2
  2. Save question and turn into Model
  3. Edit Metadata - just map "ID" to Products.ID
    image
  4. Do a browser refresh Changing Model definition will not show changes until after browser refresh #22518
  5. Edit Metadata - do not make any changes, just click Cancel - now shows error meta is not defined
    image
  6. Trying to do anything will cause blank screen - the only "fix" is to do a browser refresh

Expected behavior

  1. Absolutely never ever end in blank screen.
  2. Cancel should not do anything, not even do another request

Information about your Metabase Installation:
Tested 0.43.1
@flamber flamber added Type:Bug Product defects Priority:P2 Average run of the mill bug Querying/Native The SQL/native query editor .Frontend .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Querying/Models aka Datasets labels May 28, 2022
@nemanjaglumac
Copy link
Member

The error sounds like #23016

@nemanjaglumac
Copy link
Member

Now when the #23016 is merged, I think this is fixed. I cannot reproduce it any more on stats and I could've never reproduced it locally.

@flamber do you mind giving it another try on stats. If it works for you as well, let's close this issue.

@flamber
Copy link
Contributor Author

flamber commented Jun 1, 2022

Will be fixed by #23059 in 0.43.3

@flamber flamber closed this as completed Jun 1, 2022
@flamber flamber added this to the 0.43.3 milestone Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daltojohnso daltojohnso

Labels
.Frontend Priority:P2 Average run of the mill bug Querying/Models aka Datasets Querying/Native The SQL/native query editor .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Projects
None yet
Milestone
0.43.3
Development

No branches or pull requests
3 participants
@flamber @daltojohnso @nemanjaglumac