Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing Model definition will not show changes until after browser refresh #22518

Closed
flamber opened this issue May 8, 2022 · 2 comments · Fixed by #24520
Closed

Changing Model definition will not show changes until after browser refresh #22518

flamber opened this issue May 8, 2022 · 2 comments · Fixed by #24520
Assignees
@ranquild
Labels
.Frontend Priority:P2 Average run of the mill bug Querying/Models aka Datasets .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.44

Comments

@flamber
Copy link
Contributor

flamber commented May 8, 2022

Describe the bug
When changing a Model's query definition, then the changes do not show until after a browser refresh, which makes it difficult to understand what is happening, and is being confused with query caching.

Workaround: After changing the query definition of a Model, then do a browser refresh.

To Reproduce

  1. Question > SQL > Sample - save as "Q1"
select 1 id, 'a' test1
  1. Turn into a Model
    image
  2. Click Summarize - it shows "ID" and "TEST1" as expected
    image
  3. Click "Edit query definition" - ex. add a column - Save changes
select 1 id, 'a' test1, 'b' test2
  1. Click Summarize - it will not show the newly added "TEST2" column, even though it's part of the results
    image
  2. Do a browser refresh - now it works as expected
    image

Expected behavior
Changes to a Model should be usable instantly without a browser refresh.

Information about your Metabase Installation:
Tested 0.42.0 thru 0.43.0

Additional context
Historically related to #9027 and friends.
@flamber flamber added Type:Bug Product defects Priority:P2 Average run of the mill bug .Frontend .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Querying/Models aka Datasets labels May 8, 2022
@flamber flamber mentioned this issue May 15, 2022
Closed
@gusaiani
Copy link
Contributor

gusaiani commented May 17, 2022 •
edited

@flamber tested it now in master branch and here it works without a browser refresh.

Can you confirm on your side, please?

@flamber
Copy link
Contributor Author

flamber commented May 17, 2022

@gusaiani I'm seeing the same problem on master e0c2058

This was referenced May 27, 2022
Closed
Closed
Closed
Closed
Closed
Closed
nemanjaglumac added a commit that referenced this issue Jun 3, 2022
@nemanjaglumac
Add repro for #22518
31f2624
@nemanjaglumac nemanjaglumac mentioned this issue Jun 3, 2022
Merged
diogormendes pushed a commit that referenced this issue Jun 3, 2022
@nemanjaglumac
Repro #22518: Changing model definition will not show changes until a…
c266bba 
…fter browser refresh (#23149) [skip ci]

* Add repro for #22518

* Reinforce the test

* Skip repro
github-actions bot pushed a commit that referenced this issue Jun 3, 2022
@nemanjaglumac
Repro #22518: Changing model definition will not show changes until a…
2232823 
…fter browser refresh (#23149) [skip ci]

* Add repro for #22518

* Reinforce the test

* Skip repro
diogormendes pushed a commit that referenced this issue Jun 3, 2022
@github-actions @nemanjaglumac
Repro #22518: Changing model definition will not show changes until a…
e241962 
…fter browser refresh (#23149) [skip ci] (#23150)

* Add repro for #22518

* Reinforce the test

* Skip repro

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Jun 3, 2022
@ranquild ranquild self-assigned this Aug 2, 2022
@ranquild ranquild mentioned this issue Aug 2, 2022
Merged
@rlotun rlotun added this to the 0.44 milestone Aug 3, 2022
@gusaiani gusaiani mentioned this issue Aug 16, 2022
Closed
@deploysentinel deploysentinel bot mentioned this issue Dec 13, 2022
Merged
@deploysentinel deploysentinel bot mentioned this issue Mar 2, 2023
Merged
This was referenced Jan 11, 2024
Merged
Merged
Merged
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@replay-io replay-io bot mentioned this issue Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ranquild ranquild

Labels
.Frontend Priority:P2 Average run of the mill bug Querying/Models aka Datasets .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.44
Development

Successfully merging a pull request may close this issue.

Reload metadata after saving a question or model metabase/metabase
5 participants
@rlotun @gusaiani @flamber @ranquild @nemanjaglumac