Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent multiple sync processes #2337

Closed
cstuder opened this issue Apr 8, 2016 · 2 comments
Closed

Prevent multiple sync processes #2337

cstuder opened this issue Apr 8, 2016 · 2 comments

Comments

@cstuder
Copy link

cstuder commented Apr 8, 2016

  • I am using the Chrome 49 browser.
  • My computer's OS is Windows 7.
  • I'm running Metabase locally from the JAR.
  • My database is MariaDB 5.5 (Using the MySQL connector).
  • My Metabase version is v0.16.1.

When syncing a particular database with 140 potentially big tables, I've inadvertently started multiple sync processes due to big tables with non-ideal indices. Some executed SQL queries by the sync took so long that it looked like the sync process failed. (Most tables didn't show any metadata)

I propose to make the syncing process more visible to the user, informing her that when selecting a database for questioning while it's still in sync.

(Side note: I'm a first time Metabase user and thought that this application was broken because I couldn't filter due to the missing metadata.)

Additionally one should be unable to launch multiple sync processes for the same database at the same time.

@agilliland
Copy link
Contributor

Yeah, we had a similar comment on #2329 . I've already got some code going that will make the sync process happen in a more natural progression so that the basic information about the tables and fields will be captured and become available within a matter of seconds, then the slower stuff can happen over a longer period of time without really affecting the ability to use the app.

I also agree that we should prevent multiple syncs from running at the same time. Probably never a valid use case for that to happen.

@tlrobinson
Copy link
Contributor

Also #649 addresses sync visibility/progress. I'm going to change the title of this one to just address the duplicate sync issue.

@tlrobinson tlrobinson changed the title Make sync in progress visible to user and prevent multiple sync processes Prevent multiple sync processes Apr 8, 2016
agilliland added a commit that referenced this issue Apr 19, 2016
…base! from actually triggering a database sync, thus only allowing a database to be syncing a single instance at a time.
@agilliland agilliland added this to the 0.17.0 milestone Apr 19, 2016
@agilliland agilliland self-assigned this Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants