Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using filter Contains on dashboard is case-insensitive, but on drill-through to question becomes case-sensitive #25908

Closed
flamber opened this issue Oct 13, 2022 · 3 comments · Fixed by #27687
Closed

Using filter Contains on dashboard is case-insensitive, but on drill-through to question becomes case-sensitive #25908

flamber opened this issue Oct 13, 2022 · 3 comments · Fixed by #27687
Assignees
@ranquild
Labels
.Correctness .Frontend Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.45.2

Comments

@flamber
Copy link
Contributor

flamber commented Oct 13, 2022

Describe the bug
Using filter Contains on dashboard is case-insensitive (#21359), but on drill-through to question becomes case-sensitive, and could give unexpected results.
Not quite sure if this is FE or BE, but feels FE.

To Reproduce

  1. Question > Sample > Products - save as "Q1" and add to dashboard
  2. On dashboard, add filter Text > Contains, connect to "Q1".Title - save dashboard
  3. Input Li (or li or LI) into filter, which will return 30 results as expected
    image
  4. But clicking question title to drill-through will cause the filter to be case-sensitive and potentially return different amount of results
    image

Information about your Metabase Installation:
Tested 0.44.4
@flamber flamber added Type:Bug Product defects Priority:P2 Average run of the mill bug Reporting/Dashboards .Correctness Querying/Parameters & Variables Filter widgets, field filters, variables etc. Querying/GUI Query builder catch-all, including simple mode .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. labels Oct 13, 2022
@nemanjaglumac nemanjaglumac added this to Backlog in Cypress Testing via automation Oct 13, 2022
@nemanjaglumac
Copy link
Member

Found this:
https://github.com/metabase/metabase/blob/master/src/metabase/driver.clj#L418:L424

nemanjaglumac added a commit that referenced this issue Oct 17, 2022
@nemanjaglumac
Add repro for #25908
5cf96b4
@nemanjaglumac nemanjaglumac mentioned this issue Oct 17, 2022
Merged
nemanjaglumac added a commit that referenced this issue Oct 17, 2022
@nemanjaglumac
Repro #25908: Using filter Contains on dashboard is case-insensitive,…
3a9c07c 
… but on drill-through to question becomes case-sensitive (#25979)
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Oct 17, 2022
@nemanjaglumac nemanjaglumac removed this from Backlog in Cypress Testing Oct 17, 2022
github-actions bot pushed a commit that referenced this issue Oct 17, 2022
@nemanjaglumac
Repro #25908: Using filter Contains on dashboard is case-insensitive,…
c598a9e 
… but on drill-through to question becomes case-sensitive (#25979)
metabase-bot bot added a commit that referenced this issue Oct 17, 2022
@metabase-bot @nemanjaglumac
Repro #25908: Using filter Contains on dashboard is case-insensitive,…
29fab4d 
… but on drill-through to question becomes case-sensitive (#25979) (#25980)

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
@nemanjaglumac
Copy link
Member

@iethree you worked on #24582 recently. Can you please take a look at this issue?

@iethree iethree self-assigned this Oct 18, 2022
@iethree iethree mentioned this issue Nov 22, 2022
Merged
@dpsutton
Copy link
Contributor

dpsutton commented Jan 9, 2023

Just want to confirm that this is FE. The contains clause can take an optional {:case-sensitive false} clause to fix.

@ranquild ranquild self-assigned this Jan 13, 2023
@ranquild ranquild mentioned this issue Jan 13, 2023
Merged
@ranquild ranquild added this to the 0.45.2 milestone Jan 13, 2023
@paoliniluis paoliniluis mentioned this issue Mar 20, 2023
Open
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ranquild ranquild

Labels
.Correctness .Frontend Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.45.2
Development

Successfully merging a pull request may close this issue.

Fix navigating from dashboard to card with string filters metabase/metabase
8 participants
@flamber @WiNloSt @dpsutton @ranquild @alxnddr @iethree @nemanjaglumac @darksciencebase