Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field custom mappings not working on (public) embedding #29346

Closed
paoliniluis opened this issue Mar 19, 2023 · 1 comment
Closed

Field custom mappings not working on (public) embedding #29346

paoliniluis opened this issue Mar 19, 2023 · 1 comment
Assignees
Labels
Administration/Table Metadata .Backend Embedding/Public Simple public iframe embeds Priority:P2 Average run of the mill bug Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone

Comments

@paoliniluis
Copy link
Contributor

Describe the bug
If you do a custom mapping over a field, the field will display remapped in filters in normal dashboards, but it won't work in public embeddings

It seems that in public dashboards we're not considering that the field is remapped, and although the API call brings the remapped values, we don't show those in the FE:
image

Logs
NA

To Reproduce

  1. go to settings->data model->orders-> change the data type to category and click on the gear on "quantity" field

  2. remap a few quantities to words

  3. create a new question with the orders table, add it to a dashboard

  4. create a dropdown filter and connect it to quantity field

  5. see the remapped values

  6. now go to settings->admin and enable public sharing

  7. go to sharing in the dashboard and use a public share, open the dashboard and see that the values are not remapped

Expected behavior
If a field is remapped we should see that as well

Screenshots/videos
Above

Information about your Metabase Installation:

  • Metabase version: 1.44.6+

Severity
P2

Additional context
NA

@paoliniluis paoliniluis added Type:Bug Product defects Priority:P2 Average run of the mill bug Querying/Parameters & Variables Filter widgets, field filters, variables etc. Administration/Table Metadata Embedding/Public Simple public iframe embeds labels Mar 19, 2023
@ranquild ranquild assigned ranquild and qnkhuat and unassigned qnkhuat Mar 20, 2023
@ranquild ranquild assigned qnkhuat and unassigned ranquild Mar 20, 2023
ranquild added a commit that referenced this issue Mar 22, 2023
@ranquild ranquild added the .Reproduced Issues reproduced in test (usually Cypress) label Mar 22, 2023
@qnkhuat
Copy link
Contributor

qnkhuat commented May 11, 2023

Fixed by #30217

This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administration/Table Metadata .Backend Embedding/Public Simple public iframe embeds Priority:P2 Average run of the mill bug Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Development

No branches or pull requests

6 participants