Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching on the model detail action page can cause it to crash #29378

Closed
iethree opened this issue Mar 20, 2023 · 0 comments · Fixed by #29399
Closed

Searching on the model detail action page can cause it to crash #29378

iethree opened this issue Mar 20, 2023 · 0 comments · Fixed by #29399
Assignees
Labels
Organization/Search Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Actions .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects

Comments

@iethree
Copy link
Contributor

iethree commented Mar 20, 2023

Describe the bug

While viewing a model's model detail page and actions tab, if you search in the global search bar using a query that returns the model that hits on an action on the page that you are currently viewing, the page crashes.

Screen Shot 2023-03-20 at 9 21 40 AM

Search appears to be overwriting certain properties (namely, the query) of the action that we're relying on in the redux store.

To Reproduce

searchbreaksmodeldetail

Steps to reproduce the behavior (if you can reproduce the bug using the Sample Database, we will find the issue faster):

  1. create a model on an actions-enable database
  2. add both implicit and custom query actions to the model via the model detail page
  3. type a search that includes the model's name in the global search bar
  4. see app crash

Information about your Metabase Installation:

{
  "browser-info": {
    "language": "en-US",
    "platform": "MacIntel",
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36",
    "vendor": "Google Inc."
  },
  "system-info": {
    "file.encoding": "UTF-8",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "18.0.1+0",
    "java.vendor": "Homebrew",
    "java.vendor.url": "https://github.com/Homebrew/homebrew-core/issues",
    "java.version": "18.0.1",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "18.0.1+0",
    "os.name": "Mac OS X",
    "os.version": "12.4",
    "user.language": "en",
    "user.timezone": "America/Denver"
  },
  "metabase-info": {
    "databases": [
      "h2",
      "postgres",
      "mysql"
    ],
    "hosting-env": "unknown",
    "application-database": "h2",
    "application-database-details": {
      "database": {
        "name": "H2",
        "version": "2.1.214 (2022-06-13)"
      },
      "jdbc-driver": {
        "name": "H2 JDBC Driver",
        "version": "2.1.214 (2022-06-13)"
      }
    },
    "run-mode": "dev",
    "version": {
      "date": "2023-03-20",
      "src_hash": "a4a2f2a3f73292931e8286d6865b70ea7c217861",
      "tag": "v0.46.0-SNAPSHOT",
      "branch": "master",
      "hash": "b8c8b07"
    },
    "settings": {
      "report-timezone": "America/Detroit"
    }
  }
}

Severity
P1, crashes app.

@iethree iethree added Type:Bug Product defects Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Organization/Search Querying/Actions .Blocker labels Mar 20, 2023
@iethree iethree self-assigned this Mar 20, 2023
@iethree iethree changed the title Searching for a model on the model detail action page can cause it to crash Searching on the model detail action page can cause it to crash Mar 20, 2023
ranquild added a commit that referenced this issue Mar 22, 2023
@ranquild ranquild added the .Reproduced Issues reproduced in test (usually Cypress) label Mar 22, 2023
ranquild added a commit that referenced this issue Mar 22, 2023
github-actions bot pushed a commit that referenced this issue Mar 22, 2023
metabase-bot bot added a commit that referenced this issue Mar 22, 2023
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Organization/Search Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Actions .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants