-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trend charts look very broken with new dashboard grid changes #31628
Comments
Recordings of behavior using various viewport widths for referenceThe question is: "Orders" table from "Sample Database" - "count" summarized by "created at: year". Before - 18 columnsbefore.mp4Now - 24 columnsnow.mp4 |
For better context please see the recordings above.
The font size of card title is dynamically calculated based on:
Differences in the font size are expected.
Spacing is also dynamically computed based on available space. What we can do is to add minimum spacing, because now it's 0 and it does not look so good.
The trend case seems to be more complex. I think these changes are necessary to address this:
@cdeweyx Does the list look good to you ? Did I miss anything? cc: @NevRA |
Yeah this looks much better. Let's give this list a go. — Thanks for the write-up and investigation here. |
Context
We updated the dashboard grid row height in #31019 and it's impacting Trend charts to make them look broken. See the first three cards in the top row of this dashboard.
Expected Behavior
...
when needed.The text was updated successfully, but these errors were encountered: