Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't subsequently run actions for different objects from dashboards #33084

Closed
Tracked by #32320
kamilmielnik opened this issue Aug 10, 2023 · 0 comments · Fixed by #33087
Closed
Tracked by #32320

Can't subsequently run actions for different objects from dashboards #33084

kamilmielnik opened this issue Aug 10, 2023 · 0 comments · Fixed by #33087
Assignees
@kamilmielnik
Labels
.Frontend support/Repro Type:Bug Product defects
Milestone
0.48

Comments

@kamilmielnik
Copy link
Contributor

kamilmielnik commented Aug 10, 2023 •
edited

Epic: #32320

Description

Broken by refactoring in #32671.

Steps to reproduce

  1. Create a model
  2. Enable basic actions in it
  3. Create a dashboard
  4. Add an ID filter to the dashboard
  5. Add an action button to the dashboard, use basic update action of created model
  6. Connect the ID filter as a parameter to the action button
  7. Set ID filter to 1
  8. Click the action button to run it
  9. Notice the update modal contains data for object with id = 1
  10. Close the modal
  11. Set ID filter to 2
  12. Click the action button to run it

Expected result: the update modal contains data for object with id = 2
Actual result: the update modal contains data for object with id = 1

Demo

2023-08-10.20-53-42.mp4
@kamilmielnik kamilmielnik mentioned this issue Aug 10, 2023
Closed
@kamilmielnik kamilmielnik self-assigned this Aug 10, 2023
@kamilmielnik kamilmielnik mentioned this issue Aug 10, 2023
Merged
kamilmielnik added a commit that referenced this issue Aug 10, 2023
@kamilmielnik
Add a repro test for #33084
c412a69
kamilmielnik added a commit that referenced this issue Aug 14, 2023
@kamilmielnik
Fix - Can't subsequently run actions for different objects from dashb…
11f8b03 
…oards (#33087)

* Fix initial values not reloading in the action modal

* Add a repro test for #33084

* Use cy.button helper
@kamilmielnik kamilmielnik added this to the 0.48 milestone Aug 14, 2023
This was referenced Aug 14, 2023
Merged
Closed
Merged
Merged
This was referenced Aug 23, 2023
Merged
Closed
Merged
@deploysentinel deploysentinel bot mentioned this issue Sep 28, 2023
Open
This was referenced Oct 6, 2023
Merged
Merged
Merged
Merged
Open
Merged
Merged
Closed
Merged
Merged
Merged
This was referenced May 7, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamilmielnik kamilmielnik

Labels
.Frontend support/Repro Type:Bug Product defects
Projects
None yet
Milestone
0.48
Development

Successfully merging a pull request may close this issue.

Fix - Can't subsequently run actions for different objects from dashboards metabase/metabase
1 participant
@kamilmielnik