Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE: MLv2 Add support for segment and metric in legacyFieldRef #36699

Closed
Tracked by #30513
uladzimirdev opened this issue Dec 12, 2023 · 0 comments · Fixed by #36718
Closed
Tracked by #30513

BE: MLv2 Add support for segment and metric in legacyFieldRef #36699

uladzimirdev opened this issue Dec 12, 2023 · 0 comments · Fixed by #36718
Assignees
@metamben
Labels
.metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Task Not a part of any Epic, used by the Task Issue Template .Team/QueryProcessor :hammer_and_wrench:
Milestone
0.49

Comments

@uladzimirdev
Copy link
Contributor

legacyFieldRef should accept segment and metric together with prev behaviour (column).

before MLv2 segments and metrics didn't support options, so the expected result should be a structure like this:

['segment', id]
@uladzimirdev uladzimirdev added the .Task Not a part of any Epic, used by the Task Issue Template label Dec 12, 2023
@metamben metamben self-assigned this Dec 12, 2023
@darksciencebase darksciencebase added .Team/QueryProcessor :hammer_and_wrench: .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib labels Dec 12, 2023
@uladzimirdev uladzimirdev mentioned this issue Dec 12, 2023
Closed
metamben added a commit that referenced this issue Dec 12, 2023
@metamben
Support segment and metric metadata -> legacy reference conversion
cc45609 
Fixes #36699.
@metamben metamben mentioned this issue Dec 12, 2023
Merged
@uladzimirdev uladzimirdev mentioned this issue Dec 13, 2023
Closed
@uladzimirdev uladzimirdev changed the title MLv2 Add support for segment and metric in legacyFieldRef BE: MLv2 Add support for segment and metric in legacyFieldRef Dec 13, 2023
@metamben metamben added this to the 0.49 milestone Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metamben metamben

Labels
.metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Task Not a part of any Epic, used by the Task Issue Template .Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Milestone
0.49
Development

Successfully merging a pull request may close this issue.

Support segment and metric metadata -> legacy reference conversion metabase/metabase
3 participants
@metamben @darksciencebase @uladzimirdev