Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLv2] [FE] View - remove AggregationPopover usage #36736

Closed
Tracked by #36108
kamilmielnik opened this issue Dec 13, 2023 · 1 comment · Fixed by #36745
Closed
Tracked by #36108

[MLv2] [FE] View - remove AggregationPopover usage #36736

kamilmielnik opened this issue Dec 13, 2023 · 1 comment · Fixed by #36745
Assignees
@kamilmielnik
Labels
.Frontend .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Team/Querying
Milestone
0.49

Comments

@kamilmielnik
Copy link
Contributor

No description provided.

@kamilmielnik kamilmielnik mentioned this issue Dec 13, 2023
Closed
@kamilmielnik kamilmielnik added .Frontend .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Team/Querying labels Dec 13, 2023
@kamilmielnik kamilmielnik self-assigned this Dec 13, 2023
@kamilmielnik
Copy link
Contributor Author

Looks like it's not used, we should just remove it. The same with #36737

@kamilmielnik kamilmielnik changed the title View - use new AggregationPicker instead of AggregationPopover View - remove AggregationPopover usage Dec 13, 2023
@kamilmielnik kamilmielnik mentioned this issue Dec 13, 2023
Merged
@kamilmielnik kamilmielnik added this to the 0.49 milestone Dec 13, 2023
@ranquild ranquild changed the title View - remove AggregationPopover usage [MLv2] [FE] View - remove AggregationPopover usage Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamilmielnik kamilmielnik

Labels
.Frontend .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Team/Querying
Projects
None yet
Milestone
0.49
Development

Successfully merging a pull request may close this issue.

Remove dead BreakoutPopover & AggregationPopover usages from View metabase/metabase
1 participant
@kamilmielnik