Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLv2] [Testing plan] Custom columns #37173

Closed
33 tasks done
Tracked by #30513
ranquild opened this issue Dec 29, 2023 · 0 comments
Closed
33 tasks done
Tracked by #30513

[MLv2] [Testing plan] Custom columns #37173

ranquild opened this issue Dec 29, 2023 · 0 comments
Assignees
Milestone

Comments

@ranquild
Copy link
Contributor

ranquild commented Dec 29, 2023

availableMetrics:

  • returns a list of metrics for the source table
  • returns an empty list when there are no metrics for the source table
  • does not return metrics for other tables not used in the query
  • does not return metrics for tables used in joins
  • does not return metrics for stages other than 0
  • does not return metrics for queries based on saved questions, both mbql and native

availableSegments:

  • same as availableMetrics

legacyRef:

  • works for columns
  • works for segments -> ["segment", 1]
  • works for metrics => ["metric", 1]

expressionClauseForLegacyExpression:

  • works for simple expressions 1 + 2
  • works for expressions with columns (with legacyRef)
  • works for expressions with segments (with legacyRef)
  • works for expressions with metrics (with legacyRef)
  • result expression can be used to create a filter with filter call
  • result expression can be used to create an aggregation with aggregate call
  • result expression can be used to create a custom column with expression call

legacyExpressionForExpressionClause:

  • works for simple expressions 1 + 2
  • works for expressions with columns
  • works for expressions with segments
  • works for expressions with metrics
  • works for filters obtained from filters call
  • works for aggregations obtained from aggregations call
  • works for custom columns obtained from expressions call
  • works with expressionClauseForLegacyExpression - should result in the original expression

withExpressionName:

  • works for filters obtained from filters call
  • works for aggregations obtained from aggregations call
  • works for custom columns obtained from expressions call
  • works for expressions obtained from expressionClauseForLegacyExpression call
  • allows to add the name for an expression without one and displayInfo uses this name
  • allows to update the name for an expression and displayInfo uses this name

expression

  • adds a new expression obtained from expressionClauseForLegacyExpression call

expressions

  • returns expressions added with expression call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants