Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLv2] [FE] Remove setDefaultQuery #37506

Closed
Tracked by #36108
ranquild opened this issue Jan 10, 2024 · 0 comments · Fixed by #37583
Closed
Tracked by #36108

[MLv2] [FE] Remove setDefaultQuery #37506

ranquild opened this issue Jan 10, 2024 · 0 comments · Fixed by #37583
Assignees
@nemanjaglumac
Labels
.Frontend .Team/QueryingComponents

Comments

@ranquild
Copy link
Contributor

ranquild commented Jan 10, 2024 •
edited

See https://metaboat.slack.com/archives/C04CYTEL9N2/p1704811032663039

setDefaultQuery was only used to set default Google Analytics clauses. Since we don't want to support this anymore, setDefaultQuery becomes a no-op. It should be removed completely.
@ranquild ranquild mentioned this issue Jan 10, 2024
Closed
@nemanjaglumac nemanjaglumac self-assigned this Jan 11, 2024
@nemanjaglumac nemanjaglumac mentioned this issue Jan 11, 2024
Merged
nemanjaglumac added a commit that referenced this issue Jan 11, 2024
@nemanjaglumac
Remove setDefaultQuery() method for queries
ed9b9c2 
This removes the `setDefaultQuery()` method for both
- StructuredQuery and
- Query

Resolves #37506
@nemanjaglumac nemanjaglumac mentioned this issue Jan 11, 2024
Merged
nemanjaglumac added a commit that referenced this issue Jan 12, 2024
@nemanjaglumac
Remove setDefaultQuery() method for queries (#37583)
b457c8d 
This removes the `setDefaultQuery()` method for both
- StructuredQuery and
- Query

Resolves #37506
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nemanjaglumac nemanjaglumac

Labels
.Frontend .Team/QueryingComponents
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove setDefaultQuery() method for queries metabase/metabase
2 participants
@ranquild @nemanjaglumac