Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLv2] [FE] DatasetEditor - isEmpty check #37515

Closed
Tracked by #36108
ranquild opened this issue Jan 10, 2024 · 0 comments · Fixed by #37567
Closed
Tracked by #36108

[MLv2] [FE] DatasetEditor - isEmpty check #37515

ranquild opened this issue Jan 10, 2024 · 0 comments · Fixed by #37567
Assignees
@nemanjaglumac
Labels
.Frontend .Team/QueryingComponents

Comments

@ranquild
Copy link
Contributor

ranquild commented Jan 10, 2024 •
edited

metabase/frontend/src/metabase/query_builder/components/DatasetEditor/DatasetEditor.jsx

Line 408 in d1df0c6

if (dataset.legacyQuery().isEmpty()) {

Could be something similar to this:

const isEmpty = question.isStructured() 
  ? Lib.databaseID(question.query()) == null
  : question.legacyQuery().isEmpty()
This was referenced Jan 10, 2024
Closed
Closed
@nemanjaglumac nemanjaglumac self-assigned this Jan 11, 2024
nemanjaglumac added a commit that referenced this issue Jan 11, 2024
@nemanjaglumac
Migrate isEmpty check for structured queries in DatasetEditor
8d189cf 
Resolves #37515
@nemanjaglumac nemanjaglumac mentioned this issue Jan 11, 2024
Merged
nemanjaglumac added a commit that referenced this issue Jan 11, 2024
@nemanjaglumac
Remove isEmpty method in StructuredQuery (#37567)
c4c2d3c 
* Migrate `isEmpty` check for structured queries in DatasetEditor

Resolves #37515

* Remove `isEmpty` method from StructuredQuery

* Remove related unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nemanjaglumac nemanjaglumac

Labels
.Frontend .Team/QueryingComponents
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove isEmpty method in StructuredQuery metabase/metabase
2 participants
@ranquild @nemanjaglumac