Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLv2] [BE] [Bug] legacyRef throws when called for returnedColumns when there is an aggregation #37698

Closed
Tracked by #36108
ranquild opened this issue Jan 15, 2024 · 0 comments · Fixed by #37705
Closed
Tracked by #36108

[MLv2] [BE] [Bug] legacyRef throws when called for returnedColumns when there is an aggregation #37698

ranquild opened this issue Jan 15, 2024 · 0 comments · Fixed by #37705
Assignees
@metamben
Labels
.Backend .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Team/QueryProcessor :hammer_and_wrench:

Comments

@ranquild
Copy link
Contributor

ranquild commented Jan 15, 2024 •
edited

Blocks #37171

When there is an aggregation clause in the query, doing

Lib.returnedColumns(query, -1).map(column => Lib.legacyRef(column));

throws an error:
Screenshot 2024-01-15 at 15 49 44
This was referenced Jan 15, 2024
Closed
Closed
Merged
Closed
@ranquild ranquild added .Backend .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Team/QueryProcessor :hammer_and_wrench: labels Jan 15, 2024
@metamben metamben self-assigned this Jan 15, 2024
@ranquild ranquild mentioned this issue Jan 15, 2024
Merged
metamben added a commit that referenced this issue Jan 15, 2024
@metamben
Support converting aggregation references to legacy references
2321c7c 
Fixes #37698.
metamben added a commit that referenced this issue Jan 15, 2024
@metamben
Support converting aggregation references to legacy references
136f50a 
Fixes #37698.
@metamben metamben mentioned this issue Jan 15, 2024
Merged
kamilmielnik added a commit that referenced this issue Feb 2, 2024
@ranquild @metamben @kamilmielnik
Migrate syncStructuredQueryColumnsAndSettings to MLv2 (#37693)
f04abae 
* Migrate syncStructuredQueryColumnsAndSettings to MLv2

* Migrate syncStructuredQueryColumnsAndSettings to MLv2

* Fix types

* Support converting aggregation references to legacy references

Fixes #37698.

* Update TS wrapper

* Pass query and stageIndex to legacyQuery

* Pass query and stageIndex to legacyQuery

* Remove no longer used columnDimensionWithName

* Update assertion in failing test

* Replace non-existing Question.prototype.isNative & Question.prototype.isStructured calls

---------

Co-authored-by: Tamás Benkő <tamas@metabase.com>
Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
npfitz pushed a commit that referenced this issue Feb 5, 2024
@ranquild @metamben
@kamilmielnik @npfitz
Migrate syncStructuredQueryColumnsAndSettings to MLv2 (#37693)
eaa2767 
* Migrate syncStructuredQueryColumnsAndSettings to MLv2

* Migrate syncStructuredQueryColumnsAndSettings to MLv2

* Fix types

* Support converting aggregation references to legacy references

Fixes #37698.

* Update TS wrapper

* Pass query and stageIndex to legacyQuery

* Pass query and stageIndex to legacyQuery

* Remove no longer used columnDimensionWithName

* Update assertion in failing test

* Replace non-existing Question.prototype.isNative & Question.prototype.isStructured calls

---------

Co-authored-by: Tamás Benkő <tamas@metabase.com>
Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metamben metamben

Labels
.Backend .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support converting aggregation references to legacy references metabase/metabase
2 participants
@ranquild @metamben